Issue 7851013: Fixing shared library build of d8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7851013: Fixing shared library build of d8. (Closed)

Created:
9 years, 3 months ago by Yang

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixing shared library build of d8. Committed: http://code.google.com/p/v8/source/detail?r=9191

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	src/api.cc	View		1 chunk	+6 lines, -0 lines	1 comment	Download
	M	src/d8.cc	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. Current behavior is: - new profiler-related functions work for d8 built both shared and ...

9 years, 3 months ago (2011-09-08 09:31:24 UTC) #1

Jakob Kummerow

9 years, 3 months ago (2011-09-08 09:48:54 UTC) #2

LGTM with the copy-paste error fixed.

http://codereview.chromium.org/7851013/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/7851013/diff/1/src/api.cc#newcode4983
src/api.cc:4983: "V8::ResumeProfiler",
s/Resume/Pause/

Expand Messages | Collapse Messages