Issue 7851008: Crash fix for the case when the default profile is nuked while UI still expects it around.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7851008: Crash fix for the case when the default profile is nuked while UI still expects it around. (Closed)

Created:
9 years, 3 months ago by zel

Modified:
9 years, 3 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Crash fix for the case when the default profile is nuked while UI still expects it around. BUG=chromium-os:20171 TEST=make sure tests don't crash anymore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100080

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/login/webui_login_view.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/login/webui_login_view.cc	View		3 chunks	+2 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

xiyuan

http://codereview.chromium.org/7851008/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): http://codereview.chromium.org/7851008/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc#newcode214 chrome/browser/chromeos/login/webui_login_view.cc:214: return ProfileManager::GetDefaultProfile(); Let's return NULL here. As this is ...

9 years, 3 months ago (2011-09-08 02:12:36 UTC) #2

LGTM

Expand Messages | Collapse Messages