Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 7851008: Crash fix for the case when the default profile is nuked while UI still expects it around. (Closed)

Created:
9 years, 3 months ago by zel
Modified:
9 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org
Visibility:
Public.

Description

Crash fix for the case when the default profile is nuked while UI still expects it around. BUG=chromium-os:20171 TEST=make sure tests don't crash anymore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100080

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 3 chunks +2 lines, -4 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
zel
9 years, 3 months ago (2011-09-08 02:06:52 UTC) #1
xiyuan
http://codereview.chromium.org/7851008/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): http://codereview.chromium.org/7851008/diff/1001/chrome/browser/chromeos/login/webui_login_view.cc#newcode214 chrome/browser/chromeos/login/webui_login_view.cc:214: return ProfileManager::GetDefaultProfile(); Let's return NULL here. As this is ...
9 years, 3 months ago (2011-09-08 02:12:36 UTC) #2
xiyuan
9 years, 3 months ago (2011-09-08 02:13:35 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698