Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/ui/views/html_dialog_view.cc

Issue 7850026: Aura under Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: First version that links (and crashes) Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/html_dialog_view.cc
diff --git a/chrome/browser/ui/views/html_dialog_view.cc b/chrome/browser/ui/views/html_dialog_view.cc
index 3b4c2167262a4a2df28d39ee15172b83e8680c70..78a24af31d4adfd35770af9558325d6659f87d14 100644
--- a/chrome/browser/ui/views/html_dialog_view.cc
+++ b/chrome/browser/ui/views/html_dialog_view.cc
@@ -212,7 +212,8 @@ void HtmlDialogView::HandleKeyboardEvent(const NativeWebKeyboardEvent& event) {
// This allows stuff like F10, etc to work correctly.
DefWindowProc(event.os_event.hwnd, event.os_event.message,
event.os_event.wParam, event.os_event.lParam);
-#elif defined(TOOLKIT_USES_GTK)
+#elif defined(TOOLKIT_USES_GTK) && !defined(USE_AURA)
Ben Goodger (Google) 2011/09/16 01:11:18 In these circumstances I prefer the following flow
Emmanuel Saint-loubert-Bié 2011/09/16 02:34:54 Yes much cleaner!
+ // TODO(saintlou): provide some Aura handling.
views::NativeWidgetGtk* window_gtk =
static_cast<views::NativeWidgetGtk*>(GetWidget()->native_widget());
if (event.os_event && !event.skip_in_browser) {

Powered by Google App Engine
This is Rietveld 408576698