Add a command-line option about status email in the layout test analyzer.

Add a command-line option about status email in the layout test analyzer.

When this option is on, the analyzer sends out email only when there is
the change in the result comparing to the last result.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100400

[imasaki1, 2011-09-08 17:30:21]

Thank you!

[dennis_jeffrey, 2011-09-09 00:56:29]

LGTM

I only have minor comments here, so go ahead and submit once you look over them.
 Thank you!

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer.py (right):

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:89: help=('With this mode, email
is only sent out '
remove 'only' in this line; it's already stated in the next line below.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:91: 'analyzer result comparing
to the previous '
'comparing' --> 'compared'

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:283: status email only
when there is change in the analyzer result comparing
'comparing' --> 'compared'

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:284: to the last result.
when this is false, it sends the email out every
nit: capitalize 'w' in 'when', since it's the start of a new sentence

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:289: # Do not email when
|email_only_change_mode| is true and no change in
'no change' --> 'there is no change'

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:290: # the result
comparing to the last result.
'comparing' --> 'compared'

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:291: if
email_only_change_mode and not any(diff_map['whole']) and (
optional nit: I think it looks a little better to move the '(' from the end of
the line and instead put it right after the 'if', like this:

if (email_only_change_mode and not any(diff_map['whole']) and
    not any(diff_map['skip']) and not any(diff_map['nonskip'])):

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:293: return
indent this line by 2 fewer spaces

[imasaki1, 2011-09-09 03:03:45]

Thanks. I am going to commit.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer.py (right):

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:89: help=('With this mode, email
is only sent out '
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> remove 'only' in this line; it's already stated in the next line below.

Done.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer.py:91: 'analyzer result comparing
to the previous '
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> 'comparing' --> 'compared'

Done.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:283: status email only
when there is change in the analyzer result comparing
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> 'comparing' --> 'compared'

Done.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:284: to the last result.
when this is false, it sends the email out every
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> nit: capitalize 'w' in 'when', since it's the start of a new sentence

Done.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:289: # Do not email when
|email_only_change_mode| is true and no change in
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> 'no change' --> 'there is no change'

Done.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:290: # the result
comparing to the last result.
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> 'comparing' --> 'compared'

Done.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:291: if
email_only_change_mode and not any(diff_map['whole']) and (
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> optional nit: I think it looks a little better to move the '(' from the end of
> the line and instead put it right after the 'if', like this:
> 
> if (email_only_change_mode and not any(diff_map['whole']) and
>     not any(diff_map['skip']) and not any(diff_map['nonskip'])):

Done.

http://codereview.chromium.org/7850023/diff/2001/media/tools/layout_tests/lay...
media/tools/layout_tests/layouttest_analyzer_helpers.py:293: return
On 2011/09/09 00:56:29, dennis_jeffrey wrote:
> indent this line by 2 fewer spaces

Done.