Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 7850011: Fix wrong assert from 9180 (Closed)

Created:
9 years, 3 months ago by Rico
Modified:
9 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix wrong assert from 9180 There is an optional parameter to the function, with default value being a null handle. We then check that this is a flat string. Committed: http://code.google.com/p/v8/source/detail?r=9184

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
TBR: yang
9 years, 3 months ago (2011-09-08 06:22:38 UTC) #1
Yang
9 years, 3 months ago (2011-09-08 06:35:36 UTC) #2
On 2011/09/08 06:22:38, Rico wrote:
> TBR: yang

LGTM. Thanks for fixing that for me!

Powered by Google App Engine
This is Rietveld 408576698