Issue 7850008: lto/addAsmGlobalSymbols: fast path when no module level asm is present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7850008: lto/addAsmGlobalSymbols: fast path when no module level asm is present (Closed)

Created:
9 years, 3 months ago by krasin1

Modified:
9 years, 3 months ago

Reviewers:
nlewycky, krasin

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 3 : . #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tools/lto/LTOModule.cpp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nlewycky

LGTM http://codereview.chromium.org/7850008/diff/1/tools/lto/LTOModule.cpp File tools/lto/LTOModule.cpp (right): http://codereview.chromium.org/7850008/diff/1/tools/lto/LTOModule.cpp#newcode618 tools/lto/LTOModule.cpp:618: if (inlineAsm == "") { inlineAsm.empty(), and this ...

9 years, 3 months ago (2011-09-08 00:31:52 UTC) #2

krasin

9 years, 3 months ago (2011-09-08 00:34:23 UTC) #3

http://codereview.chromium.org/7850008/diff/1/tools/lto/LTOModule.cpp
File tools/lto/LTOModule.cpp (right):

http://codereview.chromium.org/7850008/diff/1/tools/lto/LTOModule.cpp#newcode618
tools/lto/LTOModule.cpp:618: if (inlineAsm == "") {
On 2011/09/08 00:31:52, nlewycky wrote:
> inlineAsm.empty(), and this file doesn't use {} in similar code.

Done.

Expand Messages | Collapse Messages

Issue 7850008: lto/addAsmGlobalSymbols: fast path when no module level asm is present (Closed)

Patch Set 1 #

Patch Set 2 : fix style #

Patch Set 3 : . #

Messages