Handle function proxies as getters/setters.

Handle function proxies as getters/setters.

R=kmillikin@chromium.org
BUG=v8:1543
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9407

[Jakob Kummerow, 2011-09-22 12:23:18]

LGTM with nits.

A higher-level nit is that I prefer test cases to be a lot smaller than 1800
lines. When trying to nail down a particular problem, that makes it considerably
easier to find a reduced repro case.

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1721: assertSame("", receiver)
This works, but you're implicitly testing an unrelated implementation detail
here. I'd use »assertEquals("", receiver)« instead. (Also below.)

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1726: // TODO(rossberg): test once we merge with
elements branch
nit: please indent to the same level as the surrounding code. (Also at several
places below.)

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1755: assertThrows(function(){ "use strict"; o.b
= 51 }, TypeError)
nit: space before '{'

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1774: assertEquals(0, value)  // oo has own `a'
nit: s/`/'/

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1778: assertThrows(function(){ "use strict";
oo.b = 61 }, TypeError)
nit: space before '{'

[rossberg, 2011-09-22 16:39:52]

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1721: assertSame("", receiver)
On 2011/09/22 12:23:19, Jakob wrote:
> This works, but you're implicitly testing an unrelated implementation detail
> here. I'd use »assertEquals("", receiver)« instead. (Also below.)

Done.

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1726: // TODO(rossberg): test once we merge with
elements branch
On 2011/09/22 12:23:19, Jakob wrote:
> nit: please indent to the same level as the surrounding code. (Also at several
> places below.)

Actually, uncommented the code, since the tests work on head now. :)

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1755: assertThrows(function(){ "use strict"; o.b
= 51 }, TypeError)
On 2011/09/22 12:23:19, Jakob wrote:
> nit: space before '{'

Done.

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1774: assertEquals(0, value)  // oo has own `a'
On 2011/09/22 12:23:19, Jakob wrote:
> nit: s/`/'/

Done.

http://codereview.chromium.org/7849021/diff/5001/test/mjsunit/harmony/proxies...
test/mjsunit/harmony/proxies.js:1778: assertThrows(function(){ "use strict";
oo.b = 61 }, TypeError)
On 2011/09/22 12:23:19, Jakob wrote:
> nit: space before '{'

Done.