Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/serialize.cc

Issue 7849020: Use more style-guide-friendly names for some constants. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed the long line. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 Add(reinterpret_cast<Address>(GetInternalPointer( 233 Add(reinterpret_cast<Address>(GetInternalPointer(
234 (counters->*(stats_ref_table[i].counter))())), 234 (counters->*(stats_ref_table[i].counter))())),
235 STATS_COUNTER, 235 STATS_COUNTER,
236 stats_ref_table[i].id, 236 stats_ref_table[i].id,
237 stats_ref_table[i].name); 237 stats_ref_table[i].name);
238 } 238 }
239 239
240 // Top addresses 240 // Top addresses
241 241
242 const char* AddressNames[] = { 242 const char* AddressNames[] = {
243 #define C(name) "Isolate::" #name, 243 #define BUILD_NAME_LITERAL(CamelName, hacker_name) \
244 ISOLATE_ADDRESS_LIST(C) 244 "Isolate::" #hacker_name "_address",
245 FOR_EACH_ISOLATE_ADDRESS_NAME(BUILD_NAME_LITERAL)
245 NULL 246 NULL
246 #undef C 247 #undef C
247 }; 248 };
248 249
249 for (uint16_t i = 0; i < Isolate::k_isolate_address_count; ++i) { 250 for (uint16_t i = 0; i < Isolate::kIsolateAddressCount; ++i) {
250 Add(isolate->get_address_from_id((Isolate::AddressId)i), 251 Add(isolate->get_address_from_id((Isolate::AddressId)i),
251 TOP_ADDRESS, i, AddressNames[i]); 252 TOP_ADDRESS, i, AddressNames[i]);
252 } 253 }
253 254
254 // Accessors 255 // Accessors
255 #define ACCESSOR_DESCRIPTOR_DECLARATION(name) \ 256 #define ACCESSOR_DESCRIPTOR_DECLARATION(name) \
256 Add((Address)&Accessors::name, \ 257 Add((Address)&Accessors::name, \
257 ACCESSOR, \ 258 ACCESSOR, \
258 Accessors::k##name, \ 259 Accessors::k##name, \
259 "Accessors::" #name); 260 "Accessors::" #name);
(...skipping 1263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1523 fullness_[space] = RoundUp(fullness_[space], Page::kPageSize); 1524 fullness_[space] = RoundUp(fullness_[space], Page::kPageSize);
1524 } 1525 }
1525 } 1526 }
1526 int allocation_address = fullness_[space]; 1527 int allocation_address = fullness_[space];
1527 fullness_[space] = allocation_address + size; 1528 fullness_[space] = allocation_address + size;
1528 return allocation_address; 1529 return allocation_address;
1529 } 1530 }
1530 1531
1531 1532
1532 } } // namespace v8::internal 1533 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698