Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: content/common/sandbox_mac.mm

Issue 7849011: Refactor Mac crash key reporting - move to base/mac/crash_logging.{h,mm} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/sandbox_mac.mm
diff --git a/content/common/sandbox_mac.mm b/content/common/sandbox_mac.mm
index 5ee1bc509029b9225056bd9c4db1a9601e8e9ab6..d9e64d917cf9075ed1fe51d9e602252a9d2c74f3 100644
--- a/content/common/sandbox_mac.mm
+++ b/content/common/sandbox_mac.mm
@@ -16,6 +16,7 @@ extern "C" {
#include "base/basictypes.h"
#include "base/command_line.h"
#include "base/file_util.h"
+#include "base/mac/crash_logging.h"
#include "base/mac/mac_util.h"
#include "base/rand_util_c.h"
#include "base/mac/scoped_cftyperef.h"
@@ -559,6 +560,10 @@ bool Sandbox::EnableSandbox(SandboxProcessType sandbox_type,
void Sandbox::GetCanonicalSandboxPath(FilePath* path) {
int fd = HANDLE_EINTR(open(path->value().c_str(), O_RDONLY));
if (fd < 0) {
+ base::mac::SetCrashKeyValue(
+ @"errno", [NSString stringWithFormat:@"%d", errno]);
+ base::mac::SetCrashKeyValue(@"homedir", NSHomeDirectory());
+
PLOG(FATAL) << "GetCanonicalSandboxPath() failed for: "
<< path->value();
return;
« chrome/common/child_process_logging_mac.mm ('K') | « chrome/common/mac/objc_zombie.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698