Refactor Mac crash key reporting - move to base/mac/crash_logging.{h,mm}

chrome/common/mac/objc_zombie.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/common/mac/objc_zombie.h"
 
 #include <dlfcn.h>
 #include <execinfo.h>
 #include <mach-o/dyld.h>
 #include <mach-o/nlist.h>
 
 #import <objc/objc-class.h>
 
 #include <algorithm>
 #include <iostream>
 
 #include "base/debug/stack_trace.h"
 #include "base/logging.h"
+#include "base/mac/crash_logging.h"
 #include "base/mac/mac_util.h"
 #include "base/metrics/histogram.h"
 #include "base/synchronization/lock.h"
-#import "chrome/app/breakpad_mac.h"
 #import "chrome/common/mac/objc_method_swizzle.h"
 
 // Deallocated objects are re-classed as |CrZombie|.  No superclass
 // because then the class would have to override many/most of the
 // inherited methods (|NSObject| is like a category magnet!).
 @interface CrZombie {
   Class isa;
 }
 @end
 
@@ skipping 244 matching lines @@
 
   NSString* aString =
       [NSString stringWithFormat:@"Zombie <%s: %p> received -%s",
                                  wasaName, object, sel_getName(aSelector)];
   if (viaSelector != NULL) {
     const char* viaName = sel_getName(viaSelector);
     aString = [aString stringByAppendingFormat:@" (via -%s)", viaName];
   }
 
   // Set a value for breakpad to report.
-  SetCrashKeyValue(@"zombie", aString);
+  base::mac::SetCrashKeyValue(@"zombie", aString);
 
   // Hex-encode the backtrace and tuck it into a breakpad key.
   NSString* deallocTrace = @"<unknown>";
   if (found && record.traceDepth) {
     NSMutableArray* hexBacktrace =
         [NSMutableArray arrayWithCapacity:record.traceDepth];
     for (size_t i = 0; i < record.traceDepth; ++i) {
       NSString* s = [NSString stringWithFormat:@"%p", record.trace[i]];
       [hexBacktrace addObject:s];
     }
     deallocTrace = [hexBacktrace componentsJoinedByString:@" "];
 
     // Warn someone if this exceeds the breakpad limits.
     DCHECK_LE(strlen([deallocTrace UTF8String]), 255U);
   }
-  SetCrashKeyValue(@"zombie_dealloc_bt", deallocTrace);
+  base::mac::SetCrashKeyValue(@"zombie_dealloc_bt", deallocTrace);
 
   // Log -dealloc backtrace in debug builds then crash with a useful
   // stack trace.
   if (found && record.traceDepth) {
     DCHECK(DumpDeallocTrace(record.trace, record.traceDepth));
   } else {
     DLOG(INFO) << "Unable to generate backtrace from -dealloc.";
   }
   DLOG(FATAL) << [aString UTF8String];
 
@@ skipping 238 matching lines @@
   if (oldZombies) {
     for (size_t i = 0; i < oldCount; ++i) {
       if (oldZombies[i].object)
         object_dispose(oldZombies[i].object);
     }
     free(oldZombies);
   }
 }
 
 }  // namespace ObjcEvilDoers