Refactor Mac crash key reporting - move to base/mac/crash_logging.{h,mm}

chrome/browser/chrome_browser_application_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/chrome_browser_application_mac.h"
 
 #import "base/logging.h"
+#include "base/mac/crash_logging.h"
 #import "base/mac/scoped_nsexception_enabler.h"
 #import "base/metrics/histogram.h"
 #import "base/memory/scoped_nsobject.h"
 #import "base/sys_string_conversions.h"
-#import "chrome/app/breakpad_mac.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #import "chrome/common/mac/objc_method_swizzle.h"
 #import "chrome/common/mac/objc_zombie.h"
 #include "content/browser/accessibility/browser_accessibility_state.h"
 #include "content/browser/renderer_host/render_view_host.h"
 
 // The implementation of NSExceptions break various assumptions in the
 // Chrome code.  This category defines a replacement for
@@ skipping 33 matching lines @@
     if (aName == kAcceptableNSExceptionNames[i]) {
       found = YES;
     }
   }
 
   if (!found) {
     // Update breakpad with the exception info.
     static NSString* const kNSExceptionKey = @"nsexception";
     NSString* value =
         [NSString stringWithFormat:@"%@ reason %@", aName, aReason];
-    SetCrashKeyValue(kNSExceptionKey, value);
+    base::mac::SetCrashKeyValue(kNSExceptionKey, value);
 
     // Force crash for selected exceptions to generate crash dumps.
     BOOL fatal = NO;
     if (aName == NSInternalInconsistencyException) {
       NSString* const kNSMenuItemArrayBoundsCheck =
           @"Invalid parameter not satisfying: (index >= 0) && "
           @"(index < [_itemArray count])";
       if ([aReason isEqualToString:kNSMenuItemArrayBoundsCheck]) {
         fatal = YES;
       }
@@ skipping 254 matching lines @@
     }
   } else if ([sender isKindOfClass:[NSMenuItem class]]) {
     tag = [sender tag];
   }
 
   NSString* actionString = NSStringFromSelector(anAction);
   NSString* value =
         [NSString stringWithFormat:@"%@ tag %d sending %@ to %p",
                   [sender className], tag, actionString, aTarget];
 
-  ScopedCrashKey key(kActionKey, value);
+  base::mac::ScopedCrashKey key(kActionKey, value);
 
   // Certain third-party code, such as print drivers, can still throw
   // exceptions and Chromium cannot fix them.  This provides a way to
   // work around those on a spot basis.
   bool enableNSExceptions = false;
 
   // http://crbug.com/80686 , an Epson printer driver.
   if (anAction == @selector(selectPDE:)) {
     enableNSExceptions = true;
   }
@@ skipping 47 matching lines @@
     // 10.6 has -[NSException callStackSymbols]
     // 10.5 has -[NSException callStackReturnAddresses]
     // 10.5 has backtrace_symbols().
     // I've tried to combine the latter two, but got nothing useful.
     // The addresses are right, though, maybe we could train the crash
     // server to decode them for us.
 
     NSString* value = [NSString stringWithFormat:@"%@ reason %@",
                                 [anException name], [anException reason]];
     if (!trackedFirstException) {
-      SetCrashKeyValue(kFirstExceptionKey, value);
+      base::mac::SetCrashKeyValue(kFirstExceptionKey, value);
       trackedFirstException = YES;
     } else {
-      SetCrashKeyValue(kLastExceptionKey, value);
+      base::mac::SetCrashKeyValue(kLastExceptionKey, value);
     }
 
     reportingException = NO;
   }
 
   [super reportException:anException];
 }
 
 - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attribute {
   if ([attribute isEqualToString:@"AXEnhancedUserInterface"] &&
       [value intValue] == 1) {
     BrowserAccessibilityState::GetInstance()->OnScreenReaderDetected();
     for (TabContentsIterator it;
          !it.done();
          ++it) {
       if (TabContentsWrapper* contents = *it) {
         if (RenderViewHost* rvh = contents->render_view_host()) {
           rvh->EnableRendererAccessibility();
         }
       }
     }
   }
   return [super accessibilitySetValue:value forAttribute:attribute];
 }
 
 @end