Store plug-in enabled/disabled state in PluginPrefs instead of WebPluginInfo.

webkit/plugins/npapi/plugin_list_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/npapi/plugin_list.h"
 
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/plugins/npapi/mock_plugin_list.h"
 
 namespace webkit {
 namespace npapi {
 
 namespace {
 
-bool Equals(const WebPluginInfo& a, const WebPluginInfo& b,
-            bool care_about_enabled_status) {
+bool Equals(const WebPluginInfo& a, const WebPluginInfo& b) {
   return (a.name == b.name &&
           a.path == b.path &&
           a.version == b.version &&
-          a.desc == b.desc &&
-          (!care_about_enabled_status || a.enabled == b.enabled));
+          a.desc == b.desc);
 }
 
 bool Contains(const std::vector<WebPluginInfo>& list,
-              const WebPluginInfo& plugin,
-              bool care_about_enabled_status) {
+              const WebPluginInfo& plugin) {
   for (std::vector<WebPluginInfo>::const_iterator it = list.begin();
        it != list.end(); ++it) {
-    if (Equals(*it, plugin, care_about_enabled_status))
+    if (Equals(*it, plugin))
       return true;
   }
   return false;
 }
 
 FilePath::CharType kFooPath[] = FILE_PATH_LITERAL("/plugins/foo.plugin");
 FilePath::CharType kBarPath[] = FILE_PATH_LITERAL("/plugins/bar.plugin");
 const char* kFooIdentifier = "foo";
 const char* kFooGroupName = "Foo";
 const char* kFooName = "Foo Plugin";
@@ skipping 12 matching lines @@
                     FilePath(kFooPath),
                     ASCIIToUTF16("1.2.3"),
                     ASCIIToUTF16("foo")),
         bar_plugin_(ASCIIToUTF16("Bar Plugin"),
                     FilePath(kBarPath),
                     ASCIIToUTF16("2.3.4"),
                     ASCIIToUTF16("bar")) {
   }
 
   virtual void SetUp() {
-    bar_plugin_.enabled = WebPluginInfo::USER_DISABLED_POLICY_UNMANAGED;
-    plugin_list_.DisablePlugin(bar_plugin_.path);
     plugin_list_.AddPluginToLoad(foo_plugin_);
     plugin_list_.AddPluginToLoad(bar_plugin_);
   }
 
  protected:
   MockPluginList plugin_list_;
   WebPluginInfo foo_plugin_;
   WebPluginInfo bar_plugin_;
 };
 
 TEST_F(PluginListTest, GetPlugins) {
   std::vector<WebPluginInfo> plugins;
   plugin_list_.GetPlugins(&plugins);
   EXPECT_EQ(2u, plugins.size());
-  EXPECT_TRUE(Contains(plugins, foo_plugin_, true));
-  EXPECT_TRUE(Contains(plugins, bar_plugin_, true));
+  EXPECT_TRUE(Contains(plugins, foo_plugin_));
+  EXPECT_TRUE(Contains(plugins, bar_plugin_));
 }
 
 TEST_F(PluginListTest, GetPluginGroup) {
   const PluginGroup* foo_group = plugin_list_.GetPluginGroup(foo_plugin_);
   EXPECT_EQ(ASCIIToUTF16(kFooGroupName), foo_group->GetGroupName());
-  EXPECT_TRUE(foo_group->Enabled());
-  // The second request should return a pointer to the same instance.
-  const PluginGroup* foo_group2 = plugin_list_.GetPluginGroup(foo_plugin_);
-  EXPECT_EQ(foo_group, foo_group2);
-  const PluginGroup* bar_group = plugin_list_.GetPluginGroup(bar_plugin_);
-  EXPECT_FALSE(bar_group->Enabled());
 }
 
 TEST_F(PluginListTest, EmptyGroup) {
   std::vector<PluginGroup> groups;
   plugin_list_.GetPluginGroups(false, &groups);
   for (size_t i = 0; i < groups.size(); ++i)
-    EXPECT_GE(1U, groups[i].web_plugins_info().size());
+    EXPECT_GE(1U, groups[i].web_plugin_infos().size());
 }
 
 TEST_F(PluginListTest, BadPluginDescription) {
   WebPluginInfo plugin_3043(ASCIIToUTF16(""),
                             FilePath(FILE_PATH_LITERAL("/myplugin.3.0.43")),
                             ASCIIToUTF16(""),
                             ASCIIToUTF16(""));
   // Simulate loading of the plugins.
   plugin_list_.ClearPluginsToLoad();
   plugin_list_.AddPluginToLoad(plugin_3043);
   // Now we should have them in the state we specified above.
   plugin_list_.RefreshPlugins();
   std::vector<WebPluginInfo> plugins;
   plugin_list_.GetPlugins(&plugins);
-  ASSERT_TRUE(Contains(plugins, plugin_3043, true));
-}
-
-TEST_F(PluginListTest, DisableAndEnableBeforeLoad) {
-  WebPluginInfo plugin_3043(ASCIIToUTF16("MyPlugin"),
-                            FilePath(FILE_PATH_LITERAL("/myplugin.3.0.43")),
-                            ASCIIToUTF16("3.0.43"),
-                            ASCIIToUTF16("MyPlugin version 3.0.43"));
-  WebPluginInfo plugin_3045(ASCIIToUTF16("MyPlugin"),
-                            FilePath(FILE_PATH_LITERAL("/myplugin.3.0.45")),
-                            ASCIIToUTF16("3.0.45"),
-                            ASCIIToUTF16("MyPlugin version 3.0.45"));
-  // Disable the first one and disable and then enable the second one.
-  EXPECT_TRUE(plugin_list_.DisablePlugin(plugin_3043.path));
-  EXPECT_TRUE(plugin_list_.DisablePlugin(plugin_3045.path));
-  EXPECT_TRUE(plugin_list_.EnablePlugin(plugin_3045.path));
-  // Simulate loading of the plugins.
-  plugin_list_.ClearPluginsToLoad();
-  plugin_list_.AddPluginToLoad(plugin_3043);
-  plugin_list_.AddPluginToLoad(plugin_3045);
-  // Now we should have them in the state we specified above.
-  plugin_list_.RefreshPlugins();
-  std::vector<WebPluginInfo> plugins;
-  plugin_list_.GetPlugins(&plugins);
-  plugin_3043.enabled = WebPluginInfo::USER_DISABLED_POLICY_UNMANAGED;
-  ASSERT_TRUE(Contains(plugins, plugin_3043, true));
-  ASSERT_TRUE(Contains(plugins, plugin_3045, true));
+  ASSERT_TRUE(Contains(plugins, plugin_3043));
 }
 
 TEST_F(PluginListTest, HardcodedGroups) {
   std::vector<PluginGroup> groups;
   plugin_list_.GetPluginGroups(true, &groups);
   ASSERT_EQ(2u, groups.size());
-  EXPECT_TRUE(groups[0].Enabled());
-  EXPECT_EQ(1u, groups[0].web_plugins_info().size());
+  EXPECT_EQ(1u, groups[0].web_plugin_infos().size());
   EXPECT_TRUE(groups[0].ContainsPlugin(FilePath(kFooPath)));
   EXPECT_EQ(kFooIdentifier, groups[0].identifier());
-  EXPECT_FALSE(groups[1].Enabled());
-  EXPECT_EQ(1u, groups[1].web_plugins_info().size());
+  EXPECT_EQ(1u, groups[1].web_plugin_infos().size());
   EXPECT_TRUE(groups[1].ContainsPlugin(FilePath(kBarPath)));
   EXPECT_EQ("bar.plugin", groups[1].identifier());
 }
 
-TEST_F(PluginListTest, DisableBeforeLoad) {
-  // Test that a plugin group that was disabled before plugins are loaded stays
-  // disabled afterwards.
-
-  EXPECT_TRUE(plugin_list_.EnableGroup(false, ASCIIToUTF16(kFooGroupName)));
-
-  plugin_list_.RefreshPlugins();
-  std::vector<WebPluginInfo> plugins;
-  plugin_list_.GetPlugins(&plugins);
-  ASSERT_EQ(2u, plugins.size());
-  ASSERT_EQ(WebPluginInfo::USER_DISABLED_POLICY_UNMANAGED, plugins[0].enabled);
-}
-
 }  // namespace npapi
 }  // namespace webkit