Issue 7848017: Add "soname_version" parameter to common.gypi, v8.gyp, Makefile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7848017: Add "soname_version" parameter to common.gypi, v8.gyp, Makefile (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow

Modified:
9 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add "soname_version" parameter to common.gypi, v8.gyp, Makefile TEST=compile with component=shared_library and soname_version=1.2.3 and find "libv8-1.2.3.so" in the output. Committed: http://code.google.com/p/v8/source/detail?r=9196

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -0 lines)			Patch
M	Makefile	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. This is not a perfect solution, but it's better than nothing :-)

9 years, 3 months ago (2011-09-08 12:55:38 UTC) #1

LGTM

Expand Messages | Collapse Messages