Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 7848012: Improved phi reachability computation a bit. (Closed)

Created:
9 years, 3 months ago by Sven Panne
Modified:
9 years, 3 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Improved phi reachability computation a bit. The use-def relation between phis is mainly "forwards" (i.e. from phis with smaller IDs to ones with larger IDs), so the fixed point computation terminates faster when iterate through the phis in a "backwards" manner. This is quite visible in complex Mandreel-generated code, where a few hundred phis with non-trivial use-def chains are generated. Committed: http://code.google.com/p/v8/source/detail?r=9185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/hydrogen.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 3 months ago (2011-09-08 07:21:07 UTC) #1
danno
9 years, 3 months ago (2011-09-08 07:37:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698