Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 7848010: Add a copy of the SMHasher library. MurmurHash3 will be used by SafeBrowsing phishing detection. (Closed)

Created:
9 years, 3 months ago by Brian Ryner
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Garrett Casto
Visibility:
Public.

Description

Add a copy of the SMHasher library. MurmurHash3 will be used by SafeBrowsing phishing detection. We'll be modifying the page_words field in ClientSideModel with murmurhash3's of the words, rather than SHA-256 hashes, since SHA-256 is fairly expensive to compute. Note that on a murmurhash3 hit, we'll still do a SHA-256 check against page_terms, so this will not introduce term collisions. BUG=96060 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100347

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/smhasher/LICENSE View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/smhasher/README.chromium View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/smhasher/smhasher.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Brian Ryner
9 years, 3 months ago (2011-09-08 04:17:27 UTC) #1
noelutz
On 2011/09/08 04:17:27, Brian Ryner wrote: LGTM Did you want to mention somewhere that you're ...
9 years, 3 months ago (2011-09-08 05:02:42 UTC) #2
Brian Ryner
On 2011/09/08 05:02:42, noelutz wrote: > Did you want to mention somewhere that you're only ...
9 years, 3 months ago (2011-09-08 06:44:05 UTC) #3
mattm
LGTM On 2011/09/08 06:44:05, Brian Ryner wrote: > On 2011/09/08 05:02:42, noelutz wrote: > > ...
9 years, 3 months ago (2011-09-08 23:39:14 UTC) #4
commit-bot: I haz the power
Can't apply patch for file DEPS. While running patch -p1 --forward --force; patching file DEPS ...
9 years, 3 months ago (2011-09-09 01:07:51 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-09 04:35:23 UTC) #6
Change committed as 100347

Powered by Google App Engine
This is Rietveld 408576698