DownloadId

chrome/browser/profiles/off_the_record_profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 110 matching lines @@
 
     ChromePluginServiceFilter::GetInstance()->RegisterResourceContext(
         PluginPrefs::GetForProfile(this), &GetResourceContext());
 
     BrowserThread::PostTask(
     BrowserThread::IO, FROM_HERE,
     NewRunnableFunction(&NotifyOTRProfileCreatedOnIOThread, profile_, this));
   }
 
   virtual ~OffTheRecordProfileImpl() {
+    // Shutdown the DownloadManager here in the dtor as ProfileImpl does to
+    // guarantee that it happens before the last scoped_refptr<DM> is reaped.
+    // DownloadManager is lazily created, so check before accessing it.
+    if (download_manager_.get()) {
+      // Drop our download manager so we forget about all the downloads made
+      // in incognito mode.
+      download_manager_->Shutdown();
+      download_manager_ = NULL;
+    }
+
     NotificationService::current()->Notify(
         chrome::NOTIFICATION_PROFILE_DESTROYED, Source<Profile>(this),
         NotificationService::NoDetails());
 
     ChromePluginServiceFilter::GetInstance()->UnregisterResourceContext(
         &GetResourceContext());
 
     ProfileDependencyManager::GetInstance()->DestroyProfileServices(this);
 
     BrowserThread::PostTask(
@@ skipping 374 matching lines @@
   virtual void SetupChromeOSEnterpriseExtensionObserver() {
     profile_->SetupChromeOSEnterpriseExtensionObserver();
   }
 
   virtual void InitChromeOSPreferences() {
     // The incognito profile shouldn't have Chrome OS's preferences.
     // The preferences are associated with the regular user profile.
   }
 #endif  // defined(OS_CHROMEOS)
 
   virtual void ExitedOffTheRecordMode() {

[willchan no longer on Chromium, 2011/09/12 22:09:41]

Can we get rid of this? Or is it still needed?

[benjhayden, 2011/09/14 19:25:42]

Done.

-    // DownloadManager is lazily created, so check before accessing it.
-    if (download_manager_.get()) {
-      // Drop our download manager so we forget about all the downloads made
-      // in incognito mode.
-      download_manager_->Shutdown();
-      download_manager_ = NULL;
-    }
   }
 
   virtual void OnBrowserAdded(const Browser* browser) {
   }
 
   virtual void OnBrowserRemoved(const Browser* browser) {
     if (BrowserList::GetBrowserCount(this) == 0)
       ExitedOffTheRecordMode();
   }
 
@@ skipping 184 matching lines @@
 };
 #endif
 
 Profile* Profile::CreateOffTheRecordProfile() {
 #if defined(OS_CHROMEOS)
   if (Profile::IsGuestSession())
     return new GuestSessionProfile(this);
 #endif
   return new OffTheRecordProfileImpl(this);
 }