Issue 7847007: lto/addAsmGlobalSymbols: fail fracefully when the target does not define AsmParser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7847007: lto/addAsmGlobalSymbols: fail fracefully when the target does not define AsmParser. (Closed)

Created:
9 years, 3 months ago by krasin1

Modified:
9 years, 3 months ago

Reviewers:
nlewycky, krasin

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : style fix #

Patch Set 3 : Set the proper error message #

Patch Set 4 : more clear message #

Patch Set 5 : kill tabs #

Patch Set 6 : Remove AsmParser #

Patch Set 7 : . #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+362 lines, -6 lines)			Patch
M	CMakeLists.txt	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	autoconf/configure.ac	View	1 2 3 4 5	3 chunks	+4 lines, -2 lines	0 comments	Download
M	configure	View	1 2 3 4 5	5 chunks	+6 lines, -4 lines	0 comments	Download
A	lib/Target/PNaCl/CMakeLists.txt	View	1 2 3 4 5	1 chunk	+15 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/MCTargetDesc/CMakeLists.txt	View	1 2 3 4 5	1 chunk	+13 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/MCTargetDesc/Makefile	View	1 2 3 4 5	1 chunk	+16 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/MCTargetDesc/PNaClMCAsmInfo.h	View	1 2 3 4 5	1 chunk	+29 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/MCTargetDesc/PNaClMCAsmInfo.cpp	View	1 2 3 4 5	1 chunk	+19 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/MCTargetDesc/PNaClMCTargetDesc.h	View	1 2 3 4 5	1 chunk	+26 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/MCTargetDesc/PNaClMCTargetDesc.cpp	View	1 2 3 4 5	1 chunk	+48 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/Makefile	View	1 2 3 4 5	1 chunk	+16 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/PNaCl.h	View	1 2 3 4 5	1 chunk	+28 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/PNaClTargetMachine.h	View	1 2 3 4 5	1 chunk	+45 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/PNaClTargetMachine.cpp	View	1 2 3 4 5	1 chunk	+51 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/TargetInfo/CMakeLists.txt	View	1 2 3 4 5	1 chunk	+11 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/TargetInfo/Makefile	View	1 2 3 4 5	1 chunk	+15 lines, -0 lines	0 comments	Download
A	lib/Target/PNaCl/TargetInfo/PNaClTargetInfo.cpp	View	1 2 3 4 5	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nlewycky

9 years, 3 months ago (2011-09-08 00:34:43 UTC) #2

LGTM

http://codereview.chromium.org/7847007/diff/1/tools/lto/LTOModule.cpp
File tools/lto/LTOModule.cpp (right):

http://codereview.chromium.org/7847007/diff/1/tools/lto/LTOModule.cpp#newcode632
tools/lto/LTOModule.cpp:632: if (!TAP) {
No braces.

Expand Messages | Collapse Messages