Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 7847002: Removed unneeded cairo code. (Closed)

Created:
9 years, 3 months ago by Albert Bodenhamer
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove dead cairo code. BUG= TEST=No visible changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100281

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unneeded include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1265 lines) Patch
M printing/metafile_impl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
D printing/pdf_metafile_cairo_linux.h View 1 chunk +0 lines, -88 lines 0 comments Download
D printing/pdf_metafile_cairo_linux.cc View 1 chunk +0 lines, -259 lines 0 comments Download
D printing/pdf_metafile_cairo_linux_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M printing/printing.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D skia/ext/vector_platform_device_cairo_linux.h View 1 chunk +0 lines, -131 lines 0 comments Download
D skia/ext/vector_platform_device_cairo_linux.cc View 1 chunk +0 lines, -695 lines 0 comments Download
M skia/skia.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Albert Bodenhamer
9 years, 3 months ago (2011-09-07 22:16:20 UTC) #1
vandebo (ex-Chrome)
LGTM http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h File printing/metafile_impl.h (right): http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h#newcode13 printing/metafile_impl.h:13: #include "printing/pdf_metafile_skia.h" nit: I think line 17 covers ...
9 years, 3 months ago (2011-09-07 22:26:48 UTC) #2
reed1
Yipeeee
9 years, 3 months ago (2011-09-07 22:31:34 UTC) #3
Albert Bodenhamer
http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h File printing/metafile_impl.h (right): http://codereview.chromium.org/7847002/diff/1/printing/metafile_impl.h#newcode13 printing/metafile_impl.h:13: #include "printing/pdf_metafile_skia.h" On 2011/09/07 22:26:48, vandebo wrote: > nit: ...
9 years, 3 months ago (2011-09-07 23:10:38 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-08 22:31:31 UTC) #5
Change committed as 100281

Powered by Google App Engine
This is Rietveld 408576698