Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7847: Using $CHROME_SRC_DIR in place of hash/..... (Closed)

Created:
12 years, 2 months ago by bradn
Modified:
9 years, 7 months ago
Reviewers:
tony, tc, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Using $CHROME_SRC_DIR in place of hash/.. This will facilitate changing where the main sconstruct lives. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3725

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -102 lines) Patch
M base/base_lib.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/base_unittests.scons View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M base/gfx/base_gfx.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M breakpad/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/SConscript.main View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M build/SConscript.v8 View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M build/googleurl_lib.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/googleurl_unittests.scons View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/SConscript View 1 2 3 5 chunks +12 lines, -10 lines 0 comments Download
M chrome/SConscript.automated_ui_tests View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/SConscript.ui_tests View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/SConscript View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/theme/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/SConscript View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/SConscript View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/SConscript View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/SConscript View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/plugin/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/activex_test_control/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chrome_plugin/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/memory_test/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/page_cycler/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/plugin/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/security_tests/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/selenium/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/startup/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/tab_switching/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/hunspell/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/crash_service/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/perf/flush_cache/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/test/image_diff/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gears/SConscript.googleurl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/crash_cache.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/net_lib.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/net_perftests.scons View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/net_resources.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/net_unittests.scons View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/stress_cache.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.scons View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M skia/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/libpng/libpng.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/modp_b64/modp_b64.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/SConscript View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/SConscript.javascriptcore_pcre View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/activex_shim/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/activex_shim_dll/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/build/JavaScriptCore/SConscript View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/build/localized_strings/SConscript View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/build/port/SConscript View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/default_plugin/SConscript View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/SConscript View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
12 years, 2 months ago (2008-10-22 00:47:43 UTC) #1
tony
12 years, 2 months ago (2008-10-22 17:05:05 UTC) #2 
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698