Source/WebKit/chromium/src/WebPluginContainerImpl.cpp - Issue 7846013: Merge 94721 - FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoade...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebPluginContainerImpl.cpp

Issue 7846013: Merge 94721 - FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoade... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebKit/chromium/src/WebPluginContainerImpl.cpp

===================================================================

--- Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (revision 94746)

+++ Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (working copy)

@@ -386,7 +386,7 @@

void WebPluginContainerImpl::loadFrameRequest(const WebURLRequest& request, const WebString& target, bool notifyNeeded, void* notifyData)

{

Frame* frame = m_element->document()->frame();

- if (!frame)

+ if (!frame || !frame->loader()->documentLoader())

return; // FIXME: send a notification in this case?

if (notifyNeeded) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »