Fixed crash when a SinglesplitView gets embdedded inside SingleSplitView

views/examples/double_split_view_example.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef VIEWS_EXAMPLES_DOUBLE_SPLIT_VIEW_EXAMPLE_H_
+#define VIEWS_EXAMPLES_DOUBLE_SPLIT_VIEW_EXAMPLE_H_
+#pragma once
+
+#include "views/controls/single_split_view.h"

[tfarina, 2011/09/09 15:15:31]

Please, instead of including this here, just forward declare it.

namespace views {
class SingleSplitView;
}

[Gajen, 2011/09/12 15:13:44]

Done.

+#include "views/examples/example_base.h"
+
+namespace examples {
+
+class DoubleSplitViewExample : public ExampleBase {
+ public:
+  explicit DoubleSplitViewExample(ExamplesMain* main);
+  virtual ~DoubleSplitViewExample();
+
+  // Overridden from ExampleBase:
+  virtual std::wstring GetExampleTitle() OVERRIDE;

[tfarina, 2011/09/09 15:15:31]

could you include base/compiler_specific.h for OVERRIDE?

[Gajen, 2011/09/12 15:13:44]

Done.

+  virtual void CreateExampleView(views::View* container) OVERRIDE;
+
+ private:
+  // The SinleSplitViews to be embedded.
+  views::SingleSplitView* outer_single_split_view_;
+  views::SingleSplitView* inner_single_split_view_;
+
+  DISALLOW_COPY_AND_ASSIGN(DoubleSplitViewExample);

[tfarina, 2011/09/09 15:15:31]

could you include base/basictypes.h for DISALLOW?

[Gajen, 2011/09/12 15:13:44]

Done.

+};
+
+}  // namespace examples
+
+#endif  // VIEWS_EXAMPLES_DOUBLE_SPLIT_VIEW_EXAMPLE_H_