Fixed crash when a SinglesplitView gets embdedded inside SingleSplitView

views/controls/single_split_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/single_split_view.h"
 
 #if defined(OS_LINUX)
 #include <gdk/gdk.h>
 #endif
 
@@ skipping 228 matching lines @@
         divider_offset = kDividerSize;
     }
   }
   return divider_offset;
 }
 
 int SingleSplitView::NormalizeDividerOffset(int divider_offset,
                                             const gfx::Rect& bounds) const {
   int primary_axis_size = GetPrimaryAxisSize(bounds.width(), bounds.height());
   if (divider_offset < 0)
-    return (primary_axis_size - kDividerSize) / 2;
+    // Prevents negative check fail in gfx::Size() for an embedded

[sky, 2011/09/09 15:32:23]

For a comment, how about 'primary_axis_size may < kDividerSize during initial
layout'

[Gajen, 2011/09/12 15:13:44]

Agreed but it won't add more value b'coz
0)Adds one more flag and a condition which gets checked every time in subsequent
Layout and MousePressed events too.

1)Currently there is no other code path than this Method(NormalizeDividerOffset)
which depends on this condition.

This way we save bit space and few instructions to be executed.

I guess, if in future more dependency comes on this condition then we may think
of adding this condition.

Please let me know your comments/suggestions

+    // SingleSplitView on very first Layout.
+    return std::max(0, (primary_axis_size - kDividerSize) / 2);
   return std::min(divider_offset,
                   std::max(primary_axis_size - kDividerSize, 0));
 }
 
 }  // namespace views