Fixed crash when a SinglesplitView gets embdedded inside SingleSplitView

views/controls/single_split_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/single_split_view.h"
 
 #if defined(OS_LINUX)
 #include <gdk/gdk.h>
 #endif
 
@@ skipping 228 matching lines @@
         divider_offset = kDividerSize;
     }
   }
   return divider_offset;
 }
 
 int SingleSplitView::NormalizeDividerOffset(int divider_offset,
                                             const gfx::Rect& bounds) const {
   int primary_axis_size = GetPrimaryAxisSize(bounds.width(), bounds.height());
   if (divider_offset < 0)
-    return (primary_axis_size - kDividerSize) / 2;
+    // Prevents negative check fail in gfx:Size()for embedded SingleSplitView

[tfarina, 2011/09/08 20:39:45]

add space between gfx::Size() and for

and "for an embedded SingleSplitView." ?

[Gajen, 2011/09/09 13:58:02]

Done.

+    // on very first Layout.
+    return std::max(0, ((primary_axis_size - kDividerSize) / 2));

[tfarina, 2011/09/08 20:39:45]

is there an extra (unnecessary) parentheses around the second argument of
std::max?! 

[Gajen, 2011/09/09 13:58:02]

Done.

+
   return std::min(divider_offset,

[sky, 2011/09/08 14:27:11]

Put the std::max call here, eg std::max(0, divider_offset) ...

                   std::max(primary_axis_size - kDividerSize, 0));
 }
 
 }  // namespace views