Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 7845029: Stop restricting the sender object path for incoming signals. (Closed)

Created:
9 years, 3 months ago by satorux1
Modified:
9 years, 3 months ago
Reviewers:
cwolfe
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Stop restricting the sender object path for incoming signals. Restricting the sender path makes it impossible to test signal handling with dbus-send --type=signal, as it uses "/" as the sender object path. For now, let's remove the restriction. We can make this restriction customizable when it becomes necessary. This is for http://codereview.chromium.org/7862020/ TEST=dbus_unittests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
M dbus/end_to_end_async_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M dbus/object_proxy.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M dbus/test_service.h View 1 chunk +7 lines, -0 lines 0 comments Download
M dbus/test_service.cc View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
I think this patch will make your life easier. :)
9 years, 3 months ago (2011-09-12 22:49:26 UTC) #1
cwolfe
On 2011/09/12 22:49:26, satorux1 wrote: > I think this patch will make your life easier. ...
9 years, 3 months ago (2011-09-14 15:57:06 UTC) #2
cwolfe
9 years, 3 months ago (2011-09-14 22:08:02 UTC) #3
Did a more detailed pass. LGTM

Powered by Google App Engine
This is Rietveld 408576698