[Multi Profile] Don't allow the user to choose an empty profile name.

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   const localStrings = new LocalStrings();
 
@@ skipping 90 matching lines @@
      * Set a dictionary of all profile names. These are used to prevent the
      * user from naming two profiles the same.
      * @param {Object} profileNames A dictionary of profile names.
      * @private
      */
     receiveProfileNames_: function(profileNames) {
       this.profileNames_ = profileNames;
     },
 
     /**
-     * Determine whether |name| is valid; i.e. not equal to any other profile
-     * name.
-     * @param {string} name The profile name to validate.
-     * @return true if the name is not equal to any other profile name.
+     * Display the error bubble, with |errorText| in the bubble.
+     * @param {string} errorText The localized string id to display as an error.
      * @private
      */
-    isNameValid_: function(name) {
-      // if the name hasn't changed, assume it is valid.
-      if (name == this.profileInfo_.name)
-        return true;
+    showErrorBubble_: function(errorText) {
+      var nameErrorEl = $('manage-profile-error-bubble');
+      nameErrorEl.hidden = false;
+      nameErrorEl.textContent = localStrings.getString(errorText);
 
-      return this.profileNames_[name] == undefined;
+      $('manage-profile-ok').disabled = true;
     },
 
     /**
-     * Update the UI elements accordingly if the profile name is valid/invalid.
-     * @param {boolean} isValid True if the UI should be updated as if the name
-     *     were valid.
+     * Hide the error bubble.
      * @private
      */
-    setNameIsValid_: function(isValid) {
-      var dupeNameErrorEl = $('manage-profile-duplicate-name-error');
-      if (isValid)
-        dupeNameErrorEl.classList.add('hiding');
-      else
-        dupeNameErrorEl.classList.remove('hiding');
-
-      $('manage-profile-ok').disabled = !isValid;
+    hideErrorBubble_: function() {
+      $('manage-profile-error-bubble').hidden = true;
+      $('manage-profile-ok').disabled = false;
     },
 
     /**
      * oninput callback for <input> field.
      * @param event The event object
      * @private
      */
     onNameChanged_: function(event) {
-      this.setNameIsValid_(this.isNameValid_(event.target.value));
+      var newName = event.target.value;
+      var oldName = this.profileInfo_.name;
+
+      if (newName == oldName) {
+        this.hideErrorBubble_();
+      } else if (this.profileNames_[newName] != undefined) {
+        this.showErrorBubble_('manageProfilesDuplicateNameError');
+      } else {
+        this.hideErrorBubble_();
+
+        var nameIsValid = $('manage-profile-name').validity.valid;
+        $('manage-profile-ok').disabled = !nameIsValid;
+      }
     },
 
     /**
-     * Called when the user clicks "OK". Saves the newly changed profile info.
+     * Called when the user clicks "OK". Save the newly changed profile info.

[James Hawkins, 2011/09/13 21:34:41]

Saves is correct.

      * @private
      */
     submitManageChanges_: function() {
       var name = $('manage-profile-name').value;
       var iconURL = $('manage-profile-icon-grid').selectedItem;
       chrome.send('setProfileNameAndIcon',
                   [this.profileInfo_.filePath, name, iconURL]);
     },
 
     /**
      * Display the "Manage Profile" dialog.
      * @param {Object} profileInfo The profile object of the profile to manage.
      * @private
      */
     showManageDialog_: function(profileInfo) {
       ManageProfileOverlay.setProfileInfo(profileInfo);
       $('manage-profile-overlay-manage').hidden = false;
       $('manage-profile-overlay-delete').hidden = true;
-      ManageProfileOverlay.getInstance().setNameIsValid_(true);
+      ManageProfileOverlay.getInstance().hideErrorBubble_();
 
       // Intentionally don't show the URL in the location bar as we don't want
       // people trying to navigate here by hand.
       OptionsPage.showPageByName('manageProfile', false);
     },
 
     /**
      * Display the "Delete Profile" dialog.
      * @param {Object} profileInfo The profile object of the profile to delete.
      * @private
@@ skipping 22 matching lines @@
     ManageProfileOverlay[name] = function(value) {
       ManageProfileOverlay.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay
   };
 });