Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7845004: [Multi Profile] Don't allow the user to choose an empty profile name. (Closed)

Created:
9 years, 3 months ago by binji
Modified:
9 years, 3 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[Multi Profile] Don't allow the user to choose an empty profile name. BUG=94433 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102220

Patch Set 1 #

Total comments: 1

Patch Set 2 : " #

Total comments: 2

Patch Set 3 : " #

Total comments: 4

Patch Set 4 : " #

Total comments: 1

Patch Set 5 : merge + fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.css View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.html View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 3 4 3 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
binji
9 years, 3 months ago (2011-09-12 21:49:10 UTC) #1
sail
http://codereview.chromium.org/7845004/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7845004/diff/1/chrome/app/generated_resources.grd#newcode13705 chrome/app/generated_resources.grd:13705: The profile name can't be empty. How about "The ...
9 years, 3 months ago (2011-09-12 21:57:18 UTC) #2
binji
On 2011/09/12 21:57:18, sail wrote: > http://codereview.chromium.org/7845004/diff/1/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > http://codereview.chromium.org/7845004/diff/1/chrome/app/generated_resources.grd#newcode13705 > ...
9 years, 3 months ago (2011-09-12 22:13:36 UTC) #3
binji
Now the input box is pink when empty (consistent with other UI in the settings ...
9 years, 3 months ago (2011-09-13 19:04:42 UTC) #4
James Hawkins
http://codereview.chromium.org/7845004/diff/5001/chrome/browser/resources/options/manage_profile_overlay.html File chrome/browser/resources/options/manage_profile_overlay.html (right): http://codereview.chromium.org/7845004/diff/5001/chrome/browser/resources/options/manage_profile_overlay.html#newcode11 chrome/browser/resources/options/manage_profile_overlay.html:11: <div id="manage-profile-error-bubble" class="hiding"> What is class="hiding" about?
9 years, 3 months ago (2011-09-13 20:04:09 UTC) #5
binji
http://codereview.chromium.org/7845004/diff/5001/chrome/browser/resources/options/manage_profile_overlay.html File chrome/browser/resources/options/manage_profile_overlay.html (right): http://codereview.chromium.org/7845004/diff/5001/chrome/browser/resources/options/manage_profile_overlay.html#newcode11 chrome/browser/resources/options/manage_profile_overlay.html:11: <div id="manage-profile-error-bubble" class="hiding"> On 2011/09/13 20:04:09, James Hawkins wrote: ...
9 years, 3 months ago (2011-09-13 20:38:23 UTC) #6
binji
Now using [hidden] instead of .hiding.
9 years, 3 months ago (2011-09-13 21:18:17 UTC) #7
James Hawkins
http://codereview.chromium.org/7845004/diff/10001/chrome/browser/resources/options/manage_profile_overlay.css File chrome/browser/resources/options/manage_profile_overlay.css (right): http://codereview.chromium.org/7845004/diff/10001/chrome/browser/resources/options/manage_profile_overlay.css#newcode72 chrome/browser/resources/options/manage_profile_overlay.css:72: display: block !important; Alphabetize. http://codereview.chromium.org/7845004/diff/10001/chrome/browser/resources/options/manage_profile_overlay.html File chrome/browser/resources/options/manage_profile_overlay.html (right): http://codereview.chromium.org/7845004/diff/10001/chrome/browser/resources/options/manage_profile_overlay.html#newcode11 ...
9 years, 3 months ago (2011-09-13 21:21:14 UTC) #8
binji
http://codereview.chromium.org/7845004/diff/10001/chrome/browser/resources/options/manage_profile_overlay.css File chrome/browser/resources/options/manage_profile_overlay.css (right): http://codereview.chromium.org/7845004/diff/10001/chrome/browser/resources/options/manage_profile_overlay.css#newcode72 chrome/browser/resources/options/manage_profile_overlay.css:72: display: block !important; On 2011/09/13 21:21:14, James Hawkins wrote: ...
9 years, 3 months ago (2011-09-13 21:28:32 UTC) #9
James Hawkins
LGTM with nit. http://codereview.chromium.org/7845004/diff/6004/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): http://codereview.chromium.org/7845004/diff/6004/chrome/browser/resources/options/manage_profile_overlay.js#newcode154 chrome/browser/resources/options/manage_profile_overlay.js:154: * Called when the user clicks ...
9 years, 3 months ago (2011-09-13 21:34:41 UTC) #10
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 01:05:03 UTC) #11 
Change committed as 102220

Powered by Google App Engine
This is Rietveld 408576698