Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: ppapi/proxy/dispatcher.h

Issue 7844018: Revert 100748 - This patch tries to remove most of the manual registration for Pepper interfaces,... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/ppapi_shared.gypi ('k') | ppapi/proxy/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/dispatcher.h
===================================================================
--- ppapi/proxy/dispatcher.h (revision 100753)
+++ ppapi/proxy/dispatcher.h (working copy)
@@ -17,7 +17,6 @@
#include "ppapi/proxy/callback_tracker.h"
#include "ppapi/proxy/proxy_channel.h"
#include "ppapi/proxy/interface_id.h"
-#include "ppapi/proxy/interface_list.h"
#include "ppapi/proxy/interface_proxy.h"
#include "ppapi/proxy/plugin_var_tracker.h"
@@ -58,10 +57,8 @@
return serialization_rules_.get();
}
- // Returns a non-owning pointer to the interface proxy for the given ID, or
- // NULL if the ID isn't found. This will create the proxy if it hasn't been
- // created so far.
- InterfaceProxy* GetInterfaceProxy(InterfaceID id);
+ // Wrapper for calling the local GetInterface function.
+ const void* GetLocalInterface(const char* interface_name);
// Returns the pointer to the IO thread for processing IPC messages.
// TODO(brettw) remove this. It's a hack to support the Flash
@@ -87,7 +84,14 @@
return callback_tracker_;
}
- GetInterfaceFunc local_get_interface() const { return local_get_interface_; }
+ // Retrieves the information associated with the given interface, identified
+ // either by name or ID. Each function searches either PPP or PPB interfaces.
+ static const InterfaceProxy::Info* GetPPBInterfaceInfo(
+ const std::string& name);
+ static const InterfaceProxy::Info* GetPPBInterfaceInfo(
+ InterfaceID id);
+ static const InterfaceProxy::Info* GetPPPInterfaceInfo(
+ const std::string& name);
protected:
Dispatcher(base::ProcessHandle remote_process_handle,
@@ -97,21 +101,11 @@
// Takes ownership of the given pointer, which must be on the heap.
void SetSerializationRules(VarSerializationRules* var_serialization_rules);
- // Called when an invalid message is received from the remote site. The
- // default implementation does nothing, derived classes can override.
- virtual void OnInvalidMessageReceived();
-
bool disallow_trusted_interfaces() const {
return disallow_trusted_interfaces_;
}
private:
- friend class HostDispatcherTest;
- friend class PluginDispatcherTest;
-
- // Lists all lazily-created interface proxies.
- scoped_ptr<InterfaceProxy> proxies_[INTERFACE_ID_COUNT];
-
bool disallow_trusted_interfaces_;
GetInterfaceFunc local_get_interface_;
« no previous file with comments | « ppapi/ppapi_shared.gypi ('k') | ppapi/proxy/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698