Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: ppapi/proxy/plugin_dispatcher_unittest.cc

Issue 7844018: Revert 100748 - This patch tries to remove most of the manual registration for Pepper interfaces,... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/plugin_dispatcher.cc ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_dispatcher_unittest.cc
===================================================================
--- ppapi/proxy/plugin_dispatcher_unittest.cc (revision 100753)
+++ ppapi/proxy/plugin_dispatcher_unittest.cc (working copy)
@@ -53,7 +53,7 @@
PluginDispatcherTest() {}
bool HasTargetProxy(InterfaceID id) {
- return !!plugin_dispatcher()->proxies_[id].get();
+ return !!plugin_dispatcher()->target_proxies_[id].get();
}
};
@@ -64,6 +64,11 @@
// Sending a request for a random interface should fail.
EXPECT_FALSE(SupportsInterface("Random interface"));
+ // Sending a request for a PPB interface should fail even though we've
+ // registered it as existing in the GetInterface function (the plugin proxy
+ // should only respond to PPP interfaces when asked if it supports them).
+ EXPECT_FALSE(SupportsInterface(PPB_AUDIO_INTERFACE));
+
// Sending a request for a supported PPP interface should succeed.
EXPECT_TRUE(SupportsInterface(PPP_INSTANCE_INTERFACE));
}
« no previous file with comments | « ppapi/proxy/plugin_dispatcher.cc ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698