Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: ppapi/proxy/plugin_dispatcher_unittest.cc

Issue 7844018: Revert 100748 - This patch tries to remove most of the manual registration for Pepper interfaces,... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/proxy/plugin_dispatcher.cc ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "ipc/ipc_message_utils.h" 6 #include "ipc/ipc_message_utils.h"
7 #include "ppapi/c/ppb_audio.h" 7 #include "ppapi/c/ppb_audio.h"
8 #include "ppapi/c/ppp_instance.h" 8 #include "ppapi/c/ppp_instance.h"
9 #include "ppapi/proxy/ppapi_messages.h" 9 #include "ppapi/proxy/ppapi_messages.h"
10 #include "ppapi/proxy/ppapi_proxy_test.h" 10 #include "ppapi/proxy/ppapi_proxy_test.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 PPP_Instance dummy_ppp_instance_interface = {}; 47 PPP_Instance dummy_ppp_instance_interface = {};
48 48
49 } // namespace 49 } // namespace
50 50
51 class PluginDispatcherTest : public PluginProxyTest { 51 class PluginDispatcherTest : public PluginProxyTest {
52 public: 52 public:
53 PluginDispatcherTest() {} 53 PluginDispatcherTest() {}
54 54
55 bool HasTargetProxy(InterfaceID id) { 55 bool HasTargetProxy(InterfaceID id) {
56 return !!plugin_dispatcher()->proxies_[id].get(); 56 return !!plugin_dispatcher()->target_proxies_[id].get();
57 } 57 }
58 }; 58 };
59 59
60 TEST_F(PluginDispatcherTest, SupportsInterface) { 60 TEST_F(PluginDispatcherTest, SupportsInterface) {
61 RegisterTestInterface(PPB_AUDIO_INTERFACE, &dummy_audio_interface); 61 RegisterTestInterface(PPB_AUDIO_INTERFACE, &dummy_audio_interface);
62 RegisterTestInterface(PPP_INSTANCE_INTERFACE, &dummy_ppp_instance_interface); 62 RegisterTestInterface(PPP_INSTANCE_INTERFACE, &dummy_ppp_instance_interface);
63 63
64 // Sending a request for a random interface should fail. 64 // Sending a request for a random interface should fail.
65 EXPECT_FALSE(SupportsInterface("Random interface")); 65 EXPECT_FALSE(SupportsInterface("Random interface"));
66 66
67 // Sending a request for a PPB interface should fail even though we've
68 // registered it as existing in the GetInterface function (the plugin proxy
69 // should only respond to PPP interfaces when asked if it supports them).
70 EXPECT_FALSE(SupportsInterface(PPB_AUDIO_INTERFACE));
71
67 // Sending a request for a supported PPP interface should succeed. 72 // Sending a request for a supported PPP interface should succeed.
68 EXPECT_TRUE(SupportsInterface(PPP_INSTANCE_INTERFACE)); 73 EXPECT_TRUE(SupportsInterface(PPP_INSTANCE_INTERFACE));
69 } 74 }
70 75
71 TEST_F(PluginDispatcherTest, PPBCreation) { 76 TEST_F(PluginDispatcherTest, PPBCreation) {
72 // Sending a PPB message out of the blue should create a target proxy for 77 // Sending a PPB message out of the blue should create a target proxy for
73 // that interface in the plugin. 78 // that interface in the plugin.
74 EXPECT_FALSE(HasTargetProxy(INTERFACE_ID_PPB_AUDIO)); 79 EXPECT_FALSE(HasTargetProxy(INTERFACE_ID_PPB_AUDIO));
75 PpapiMsg_PPBAudio_NotifyAudioStreamCreated audio_msg( 80 PpapiMsg_PPBAudio_NotifyAudioStreamCreated audio_msg(
76 INTERFACE_ID_PPB_AUDIO, HostResource(), 0, 81 INTERFACE_ID_PPB_AUDIO, HostResource(), 0,
77 IPC::PlatformFileForTransit(), base::SharedMemoryHandle(), 0); 82 IPC::PlatformFileForTransit(), base::SharedMemoryHandle(), 0);
78 plugin_dispatcher()->OnMessageReceived(audio_msg); 83 plugin_dispatcher()->OnMessageReceived(audio_msg);
79 EXPECT_TRUE(HasTargetProxy(INTERFACE_ID_PPB_AUDIO)); 84 EXPECT_TRUE(HasTargetProxy(INTERFACE_ID_PPB_AUDIO));
80 } 85 }
81 86
82 } // namespace proxy 87 } // namespace proxy
83 } // namespace ppapi 88 } // namespace ppapi
84 89
OLDNEW
« no previous file with comments | « ppapi/proxy/plugin_dispatcher.cc ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698