Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 7843002: mac: Switch the default compiler to clang for everyone. (Closed)

Created:
9 years, 3 months ago by Nico
Modified:
9 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Avi (use Gerrit)
Visibility:
Public.

Description

mac: Switch the default compiler to clang for everyone. Also commit http://codereview.chromium.org/7890052/ as part of this CL, so that new pch files are created for clang automatically. BUG=none TEST=devs get happier, not too many bots break Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101239

Patch Set 1 #

Patch Set 2 : pch path, too #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M build/common.gypi View 1 3 chunks +4 lines, -8 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
When I use this with Xcode 3 I find that sometimes I make a change ...
9 years, 3 months ago (2011-09-08 15:33:44 UTC) #1
Nico
Thanks, Avi! For posterity, that was http://crbug.com/96315 Mark: I think things are ready enough to ...
9 years, 3 months ago (2011-09-14 22:44:18 UTC) #2
Mark Mentovai
9 years, 3 months ago (2011-09-15 02:54:58 UTC) #3
LGTM

http://codereview.chromium.org/7843002/diff/3001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7843002/diff/3001/build/common.gypi#newcode564
build/common.gypi:564: # Enable clang on mac by default!
LGTM!

Powered by Google App Engine
This is Rietveld 408576698