fix know issues in RenderText

views/controls/textfield/textfield_views_model.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/textfield/textfield_views_model.h"
 
 #include <algorithm>
 
 #include "base/i18n/break_iterator.h"
 #include "base/logging.h"
@@ skipping 302 matching lines @@
     render_text_->SetCursorPosition(new_cursor);
   }
   ClearSelection();
   return changed;
 }
 
 void TextfieldViewsModel::Append(const string16& text) {
   if (HasCompositionText())
     ConfirmCompositionText();
   size_t save = GetCursorPosition();
-  MoveCursorRight(gfx::LINE_BREAK, false);
+  if (render_text_->GetTextDirection() == base::i18n::LEFT_TO_RIGHT)
+    MoveCursorRight(gfx::LINE_BREAK, false);
+  else
+    MoveCursorLeft(gfx::LINE_BREAK, false);
   InsertText(text);
   render_text_->SetCursorPosition(save);
   ClearSelection();
 }
 
 bool TextfieldViewsModel::Delete() {
   if (HasCompositionText()) {
     // No undo/redo for composition text.
     CancelCompositionText();
     return true;
   }
   if (HasSelection()) {
     DeleteSelection();
     return true;
   }
   if (GetText().length() > GetCursorPosition()) {
     size_t cursor_position = GetCursorPosition();
-    ExecuteAndRecordDelete(cursor_position, cursor_position + 1, true);
+    size_t next_grapheme_index =
+        render_text_->GetIndexOfNextGrapheme(cursor_position);
+    ExecuteAndRecordDelete(cursor_position, next_grapheme_index, true);
     return true;
   }
   return false;
 }
 
 bool TextfieldViewsModel::Backspace() {
   if (HasCompositionText()) {
     // No undo/redo for composition text.
     CancelCompositionText();
     return true;
@@ skipping 297 matching lines @@
   }
 }
 
 void TextfieldViewsModel::ReplaceTextInternal(const string16& text,
                                               bool mergeable) {
   if (HasCompositionText()) {
     CancelCompositionText();
   } else if (!HasSelection()) {
     size_t cursor = GetCursorPosition();
     gfx::SelectionModel sel(render_text_->selection_model());
-    sel.set_selection_start(cursor + text.length());
+    sel.set_selection_start(render_text_->GetIndexOfNextGrapheme(cursor));
     render_text_->MoveCursorTo(sel);
   }
   // Edit history is recorded in InsertText.
   InsertTextInternal(text, mergeable);
 }
 
 void TextfieldViewsModel::ClearEditHistory() {
   STLDeleteContainerPointers(edit_history_.begin(),
                              edit_history_.end());
   edit_history_.clear();
@@ skipping 101 matching lines @@
   if (delete_from != delete_to)
     render_text_->SetText(text.erase(delete_from, delete_to - delete_from));
   if (!new_text.empty())
     render_text_->SetText(text.insert(new_text_insert_at, new_text));
   render_text_->SetCursorPosition(new_cursor_pos);
   // TODO(oshima): mac selects the text that is just undone (but gtk doesn't).
   // This looks fine feature and we may want to do the same.
 }
 
 }  // namespace views