Issue 7841034: Prepare push to trunk. Now working on version 3.6.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7841034: Prepare push to trunk. Now working on version 3.6.2. (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow

Modified:
9 years, 3 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.6.2. R=lrn@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9171

Patch Set 1 #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+20 lines, -0 lines	2 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 3 months ago (2011-09-07 12:34:10 UTC) #2

LGTM

http://codereview.chromium.org/7841034/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7841034/diff/1/ChangeLog#newcode9
ChangeLog:9: properties on native functions.
Explosion is too big a word. I'd drop this line. It's only a matter of 10K of
executable size for the initial snapshot. Not really interesting to users.

http://codereview.chromium.org/7841034/diff/1/ChangeLog#newcode12
ChangeLog:12: prototypes.
Ditto for this one.

Expand Messages | Collapse Messages