Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7841012: Get chrome to link with USE_AURA (Closed)

Created:
9 years, 3 months ago by Ben Goodger (Google)
Modified:
9 years, 3 months ago
Reviewers:
jam, jabdelmalek, sadrul
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, dhollowa
Visibility:
Public.

Description

Get chrome to link with USE_AURA http://crbug.com/93947 TEST=none R=sadrul TBR=jabdelmalek for the content/webkit stubs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99993

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1295 lines, -39 lines) Patch
A chrome/browser/automation/automation_provider_aura.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/automation/testing_automation_provider_aura.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chrome_plugin_message_filter.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_message_filter.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/first_run/first_run_aura.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download
A chrome/browser/platform_util_aura.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/process_singleton_aura.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views_win.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/panels/auto_hiding_desktop_bar_aura.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/ui/tabs/dock_info_aura.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.h View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/ui/views/browser_bubble_aura.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/dropdown_bar_host_aura.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/find_bar_host_aura.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_frame_aura.h View 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_frame_aura.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 9 chunks +14 lines, -2 lines 0 comments Download
A chrome/browser/ui/views/native_constrained_window_aura.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/shell_dialogs_aura.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/stubs_aura.cc View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 18 chunks +33 lines, -4 lines 0 comments Download
M chrome/default_plugin/default_plugin.gyp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/default_plugin/plugin_impl_win.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
A content/browser/renderer_host/render_message_filter_aura.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing.gyp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A views/controls/menu/native_menu_aura.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download
M views/events/event.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M views/events/event_aura.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M views/views.gyp View 1 2 3 3 chunks +1 line, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A webkit/plugins/npapi/webplugin_delegate_impl_aura.cc View 1 2 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ben Goodger (Google)
9 years, 3 months ago (2011-09-07 00:21:32 UTC) #1
Ben Goodger (Google)
On 2011/09/07 00:21:32, Ben Goodger (Google) wrote: This is everything except default_plugin.lib and glue.lib on ...
9 years, 3 months ago (2011-09-07 00:22:01 UTC) #2
sadrul
On 2011/09/07 00:22:01, Ben Goodger (Google) wrote: > On 2011/09/07 00:21:32, Ben Goodger (Google) wrote: ...
9 years, 3 months ago (2011-09-07 05:06:57 UTC) #3
Ben Goodger (Google)
OK, I think this is ready for review.
9 years, 3 months ago (2011-09-07 05:34:17 UTC) #4
sadrul
Very nice! LGTM (haven't looked for nits) http://codereview.chromium.org/7841012/diff/23/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc File chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc (right): http://codereview.chromium.org/7841012/diff/23/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc#newcode148 chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc:148: #if !defined(USE_AURA) ...
9 years, 3 months ago (2011-09-07 15:37:47 UTC) #5
Ben Goodger (Google)
On Wed, Sep 7, 2011 at 8:37 AM, <sadrul@chromium.org> wrote: > chrome/browser/ui/views/tab_**contents/native_tab_contents_** > container_aura.cc > ...
9 years, 3 months ago (2011-09-07 16:27:41 UTC) #6
Ben Goodger (Google)
jam: content/, webkit/
9 years, 3 months ago (2011-09-07 20:07:05 UTC) #7
jam
9 years, 3 months ago (2011-09-07 20:10:58 UTC) #8 
lgtm

Powered by Google App Engine
This is Rietveld 408576698