Issue 7841009: export RendererMain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7841009: export RendererMain (Closed)

Created:
9 years, 3 months ago by Dirk Pranke

Modified:
9 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Visibility:
Public.

Description

export RendererMain from content so that it will get picked up properly by chrome_main. R=jam@chromium.org BUG=90442 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100809

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge, fix comments from review feedback #

Patch Set 3 : fix typo in #include of renderer_main.h #

Patch Set 4 : fix typo in content_export.h for linux branch, comment out until we're ready to enable components #

Patch Set 5 : fix stupid preprocessor typo #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
M	chrome/app/chrome_main.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	content/app/content_main.cc	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	content/common/content_export.h	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download
A	content/renderer/renderer_main.h	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_main.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

9 years, 3 months ago (2011-09-06 23:46:33 UTC) #2

lgtm

http://codereview.chromium.org/7841009/diff/1/content/renderer/renderer_main.h
File content/renderer/renderer_main.h (right):

http://codereview.chromium.org/7841009/diff/1/content/renderer/renderer_main....
content/renderer/renderer_main.h:13: // mainline routine for running as the
Renderer process
nit: comments are supposed to use proper spelling and grammer

Expand Messages | Collapse Messages