Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 7841007: Rename browser/sync/test/live_sync directory to browser/sync/test/integration (Closed)

Created:
9 years, 3 months ago by Raghu Simha
Modified:
9 years, 3 months ago
CC:
chromium-reviews, ncarter (slow), idana, Erik does not do reviews, Nirnimesh, mihaip+watch_chromium.org, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

Rename browser/sync/test/live_sync directory to browser/sync/test/integration http://codereview.chromium.org/7828055/ moved all sync test collateral from chrome/tests to chrome/browser/sync/test. This patch renames the browser/sync/test/live_sync directory to browser/sync/test/integration, to differentiate the integration tests from other test categories (like unit tests, sync engine tests, etc.) It also renames the class LiveSyncTest to SyncTest, in keeping with the name changes that went in with the recent sync integration test framework refactor. BUG=90905 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99839

Patch Set 1 : "" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -11831 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/sync/test/integration/apps_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/apps_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/autofill_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/autofill_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/bookmarks_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/bookmarks_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/extensions_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/extensions_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/many_client_bookmarks_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/many_client_passwords_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/many_client_preferences_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/migration_errors_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/multiple_client_bookmarks_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/multiple_client_passwords_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
chrome/browser/sync/test/integration/multiple_client_preferences_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/multiple_client_sessions_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/passwords_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/passwords_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/performance/extensions_sync_perf_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/performance/sync_timing_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/performance/sync_timing_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/preferences_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/preferences_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/sessions_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
chrome/browser/sync/test/integration/sessions_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_apps_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_extensions_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_passwords_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_preferences_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_themes_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/sync/test/integration/sync_datatype_helper.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + chrome/browser/sync/test/integration/sync_datatype_helper.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + chrome/browser/sync/test/integration/sync_errors_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/sync_extension_helper.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/sync/test/integration/sync_extension_helper.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/sync_test.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/sync/test/integration/sync_test.cc View 33 chunks +51 lines, -51 lines 0 comments Download
A + chrome/browser/sync/test/integration/themes_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/themes_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_extensions_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_themes_sync_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/sync/test/integration/typed_urls_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/sync/test/integration/typed_urls_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/sync/test/live_sync/PRESUBMIT.py View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/sync/test/live_sync/apps_helper.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/sync/test/live_sync/apps_helper.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/sync/test/live_sync/autofill_helper.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/sync/test/live_sync/autofill_helper.cc View 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/browser/sync/test/live_sync/bookmarks_helper.h View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/sync/test/live_sync/bookmarks_helper.cc View 1 chunk +0 lines, -593 lines 0 comments Download
D chrome/browser/sync/test/live_sync/extensions_helper.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/sync/test/live_sync/extensions_helper.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/sync/test/live_sync/live_sync_test.h View 1 chunk +0 lines, -317 lines 0 comments Download
D chrome/browser/sync/test/live_sync/live_sync_test.cc View 1 chunk +0 lines, -632 lines 0 comments Download
D chrome/browser/sync/test/live_sync/many_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/sync/test/live_sync/many_client_passwords_sync_test.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/sync/test/live_sync/many_client_preferences_sync_test.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/sync/test/live_sync/migration_errors_test.cc View 1 chunk +0 lines, -453 lines 0 comments Download
D chrome/browser/sync/test/live_sync/multiple_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/sync/test/live_sync/multiple_client_passwords_sync_test.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/sync/test/live_sync/multiple_client_preferences_sync_test.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/sync/test/live_sync/multiple_client_sessions_sync_test.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/sync/test/live_sync/multiple_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/sync/test/live_sync/passwords_helper.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/sync/test/live_sync/passwords_helper.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/autofill_sync_perf_test.cc View 1 chunk +0 lines, -198 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/bookmarks_sync_perf_test.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/extensions_sync_perf_test.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/passwords_sync_perf_test.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/sessions_sync_perf_test.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/sync_timing_helper.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/sync_timing_helper.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/sync/test/live_sync/performance/typed_urls_sync_perf_test.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/sync/test/live_sync/preferences_helper.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/sync/test/live_sync/preferences_helper.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/sync/test/live_sync/sessions_helper.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/sync/test/live_sync/sessions_helper.cc View 1 chunk +0 lines, -294 lines 0 comments Download
chrome/browser/sync/test/live_sync/single_client_apps_sync_test.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/sync/test/live_sync/single_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/sync/test/live_sync/single_client_extensions_sync_test.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/sync/test/live_sync/single_client_passwords_sync_test.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/sync/test/live_sync/single_client_preferences_sync_test.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/sync/test/live_sync/single_client_sessions_sync_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
chrome/browser/sync/test/live_sync/single_client_themes_sync_test.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/sync/test/live_sync/single_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/sync/test/live_sync/sync_datatype_helper.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/sync/test/live_sync/sync_datatype_helper.cc View 1 chunk +0 lines, -29 lines 0 comments Download
chrome/browser/sync/test/live_sync/sync_errors_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/sync/test/live_sync/sync_extension_helper.h View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/sync/test/live_sync/sync_extension_helper.cc View 1 chunk +0 lines, -361 lines 0 comments Download
chrome/browser/sync/test/live_sync/sync_integration_test.py View 1 chunk +0 lines, -404 lines 0 comments Download
D chrome/browser/sync/test/live_sync/themes_helper.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/sync/test/live_sync/themes_helper.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_apps_sync_test.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_autofill_sync_test.cc View 1 chunk +0 lines, -409 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -1757 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_extensions_sync_test.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_passwords_sync_test.cc View 1 chunk +0 lines, -323 lines 0 comments Download
chrome/browser/sync/test/live_sync/two_client_preferences_sync_test.cc View 1 chunk +0 lines, -669 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_sessions_sync_test.cc View 1 chunk +0 lines, -353 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_themes_sync_test.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/sync/test/live_sync/two_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/sync/test/live_sync/typed_urls_helper.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/sync/test/live_sync/typed_urls_helper.cc View 1 chunk +0 lines, -184 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +77 lines, -77 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Raghu Simha
Pawel, please review. Thanks.
9 years, 3 months ago (2011-09-06 21:49:40 UTC) #1
Paweł Hajdan Jr.
Rubber stamp LGTM
9 years, 3 months ago (2011-09-06 21:57:20 UTC) #2
Raghu Simha
+willchan, for the change to profile.h.
9 years, 3 months ago (2011-09-06 22:15:54 UTC) #3
willchan no longer on Chromium
9 years, 3 months ago (2011-09-06 22:16:49 UTC) #4
LGTM

On Tue, Sep 6, 2011 at 3:15 PM,  <rsimha@chromium.org> wrote:
> +willchan, for the change to profile.h.
>
> http://codereview.chromium.org/7841007/
>

Powered by Google App Engine
This is Rietveld 408576698