Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 7841005: [ChromeOS] Use oauth's segmented spinner for sign-in loading UI. (Closed)

Created:
9 years, 3 months ago by xiyuan
Modified:
9 years, 3 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[ChromeOS] Use oauth's segmented spinner for sign-in loading UI. - Split spinner css from oobe.css into spinner.css; - Update references: oauth-enroll-spinner -> spinner, throbber -> spinner; Also make the version label wider so that RTL label shows right aligned. BUG=chromium-os:19181 TEST=Verify the Gaia loading UI uses segmented spinner now for chromium-os:19181 and RTL chromeos shows proper right aligned version info in login screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99854

Patch Set 1 #

Patch Set 2 : add missing spinner.css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.css View 2 chunks +1 line, -27 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_signin.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_signin.js View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/resources/chromeos/login/spinner.css View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xiyuan
9 years, 3 months ago (2011-09-06 20:24:12 UTC) #1
achuithb
On 2011/09/06 20:24:12, xiyuan wrote: LGTM
9 years, 3 months ago (2011-09-06 20:26:18 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-09-06 23:04:45 UTC) #3
Change committed as 99854

Powered by Google App Engine
This is Rietveld 408576698