Don't pass URLBlacklistManager from UI to IO through ProfileParams on ProfileIOData.

Don't pass URLBlacklistManager from UI to IO through ProfileParams on ProfileIOData.

If the ProfileIOData isn't ever lazily initialized, the URLBlacklistManager will be deleted with the ProfileParams on the wrong thread.

BUG=95510
TEST=sync_integration_tests aren't breaking because of destruction of URLBlacklistManager on the wrong thread


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99876

[Joao da Silva, 2011-09-06 19:40:34]

Please review.

Thanks for proposing the fix. This works locally, I'll wait for the bots before
committing. I'm not sure about the code at the end of InitializeProfileParams,
it's not quite what the method is meant to do.

[willchan no longer on Chromium, 2011-09-06 20:49:27]

I've proposed renaming the function so that it does what it sounds like it's
supposed to do.

http://codereview.chromium.org/7841004/diff/1/chrome/browser/profiles/profile...
File chrome/browser/profiles/profile_io_data.cc (right):

http://codereview.chromium.org/7841004/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_io_data.cc:192: void
ProfileIOData::InitializeProfileParams(Profile* profile) {
Please rename this to InitializeOnUIThread() since we're doing more than just
initializing the ProfileParams now.

[Joao da Silva, 2011-09-06 21:07:16]

Please have another look. Does the change to suppressions.txt make sense?

http://codereview.chromium.org/7841004/diff/1/chrome/browser/profiles/profile...
File chrome/browser/profiles/profile_io_data.cc (right):

http://codereview.chromium.org/7841004/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_io_data.cc:192: void
ProfileIOData::InitializeProfileParams(Profile* profile) {
On 2011/09/06 20:49:27, willchan wrote:
> Please rename this to InitializeOnUIThread() since we're doing more than just
> initializing the ProfileParams now.

Done.

http://codereview.chromium.org/7841004/diff/3002/tools/valgrind/memcheck/supp...
File tools/valgrind/memcheck/suppressions.txt (right):

http://codereview.chromium.org/7841004/diff/3002/tools/valgrind/memcheck/supp...
tools/valgrind/memcheck/suppressions.txt:3657:
fun:_ZN13ProfileIOData20InitializeOnUIThreadEP7Profile
Manual name mangling... c++filt turns this into the expected signature. wdyt?

[willchan no longer on Chromium, 2011-09-06 21:15:45]

LGTM

http://codereview.chromium.org/7841004/diff/3002/tools/valgrind/memcheck/supp...
File tools/valgrind/memcheck/suppressions.txt (right):

http://codereview.chromium.org/7841004/diff/3002/tools/valgrind/memcheck/supp...
tools/valgrind/memcheck/suppressions.txt:3657:
fun:_ZN13ProfileIOData20InitializeOnUIThreadEP7Profile
On 2011/09/06 21:07:16, Joao da Silva wrote:
> Manual name mangling... c++filt turns this into the expected signature. wdyt?

Sure...give it a shot. If it doesn't work, then valgrind will whine and you can
fix it later.

[commit-bot: I haz the power, 2011-09-07 00:18:59]

Change committed as 99876