Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/browser_main.h

Issue 7840041: Refactor some more BrowserMain code. Move core code that's required by all embedders to content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_main.cc » ('j') | chrome/browser/browser_main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_main.h
===================================================================
--- chrome/browser/browser_main.h (revision 100153)
+++ chrome/browser/browser_main.h (working copy)
@@ -11,12 +11,17 @@
#include "base/metrics/field_trial.h"
#include "base/tracked_objects.h"
#include "content/browser/browser_main.h"
+#include "chrome/browser/first_run/first_run.h"
tony 2011/09/08 17:21:04 Nit: alphabetize
jam 2011/09/08 17:43:01 Done.
+class BrowserProcessImpl;
class FieldTrialSynchronizer;
class HistogramSynchronizer;
class MetricsService;
class PrefService;
+class ProcessSingleton;
+class Profile;
class ShutdownWatcherHelper;
+class TranslateManager;
namespace chrome_browser {
// For use by ShowMissingLocaleMessageBox.
@@ -28,10 +33,6 @@
public:
virtual ~ChromeBrowserMainParts();
- // Constructs HistogramSynchronizer which gets released early (before
- // main_message_loop_).
- void SetupHistogramSynchronizer();
-
// Constructs metrics service and does related initialization, including
// creation of field trials. Call only after labs have been converted to
// switches.
@@ -43,10 +44,11 @@
explicit ChromeBrowserMainParts(const MainFunctionParams& parameters);
virtual void PostMainMessageLoopStart() OVERRIDE;
+ virtual void PreMainMessageLoopRun() OVERRIDE;
+ virtual void MainMessageLoopRun() OVERRIDE;
+ virtual void PostMainMessageLoopRun() OVERRIDE;
virtual void ToolkitInitialized() OVERRIDE;
- virtual int TemporaryContinue() OVERRIDE;
-
private:
// Methods for |EarlyInitialization()| ---------------------------------------
@@ -102,8 +104,15 @@
// Members initialized after / released before main_message_loop_ ------------
- // Initialized in SetupHistogramSynchronizer.
+ scoped_ptr<BrowserProcessImpl> browser_process_;
scoped_refptr<HistogramSynchronizer> histogram_synchronizer_;
+ scoped_ptr<ProcessSingleton> process_singleton_;
+ scoped_ptr<FirstRun::MasterPrefs> master_prefs_;
+ bool record_search_engine_;
+ TranslateManager* translate_manager_;
+ MetricsService* metrics_;
+ Profile* profile_;
+ bool run_message_loop_;
// Initialized in SetupMetricsAndFieldTrials.
scoped_refptr<FieldTrialSynchronizer> field_trial_synchronizer_;
« no previous file with comments | « no previous file | chrome/browser/browser_main.cc » ('j') | chrome/browser/browser_main.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698