Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: content/browser/browser_main.h

Issue 7840041: Refactor some more BrowserMain code. Move core code that's required by all embedders to content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | content/browser/browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_main.h
===================================================================
--- content/browser/browser_main.h (revision 100153)
+++ content/browser/browser_main.h (working copy)
@@ -73,11 +73,11 @@
// Parts to be called by |BrowserMain()|.
void EarlyInitialization();
+ void InitializeToolkit();
void MainMessageLoopStart();
- void InitializeToolkit();
+ void RunMainMessageLoopParts();
- // Temporary function since not all the code from chrome is moved over yet.
- virtual int TemporaryContinue();
+ int result_code() const { return result_code_; }
protected:
// Methods to be overridden to provide platform-specific code; these
@@ -86,10 +86,10 @@
virtual void PostEarlyInitialization();
virtual void PreMainMessageLoopStart();
virtual void PostMainMessageLoopStart();
+ virtual void PreMainMessageLoopRun();
+ virtual void MainMessageLoopRun();
+ virtual void PostMainMessageLoopRun();
- // Used to initialize NSPR where appropriate.
- virtual void InitializeSSL();
-
// Allows an embedder to do any extra toolkit initialization.
virtual void ToolkitInitialized();
@@ -103,6 +103,7 @@
MessageLoop& main_message_loop() const {
return *main_message_loop_;
}
+ void set_result_code(int result_code) { result_code_ = result_code; }
private:
void InitializeMainThread();
@@ -111,6 +112,7 @@
const MainFunctionParams& parameters_;
const CommandLine& parsed_command_line_;
+ int result_code_;
// Members initialized in |MainMessageLoopStart()| ---------------------------
scoped_ptr<MessageLoop> main_message_loop_;
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | content/browser/browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698