Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 7840029: Make one-character strings into symbols more agressively. (Closed)

Created:
9 years, 3 months ago by Erik Corry
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make one-character strings into symbols more agressively. Committed: http://code.google.com/p/v8/source/detail?r=9175

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/heap.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
9 years, 3 months ago (2011-09-07 12:42:37 UTC) #1
mnaganov (inactive)
On 2011/09/07 12:42:37, Erik Corry wrote: Have you tried using longer strings in the test? ...
9 years, 3 months ago (2011-09-07 12:47:03 UTC) #2
Erik Corry
Thanks! New version uploaded.
9 years, 3 months ago (2011-09-07 12:56:26 UTC) #3
mnaganov (inactive)
9 years, 3 months ago (2011-09-07 12:58:09 UTC) #4
On 2011/09/07 12:56:26, Erik Corry wrote:
> Thanks! New version uploaded.

LGTM

Powered by Google App Engine
This is Rietveld 408576698