Issue 7840019: [ntp4] Disable the bookmarks delete button, for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7840019: [ntp4] Disable the bookmarks delete button, for now. (Closed)

Created:
9 years, 3 months ago by csilv

Modified:
9 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

[ntp4] Disable the bookmarks delete button, for now. BUG=95584 TEST=Bookmark tiles should no longer have delete buttons in the upper right corner. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99996

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/ntp4/new_tab.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Evan Stade

won't this cause errors in bookmark_page.js when it tries to find the close button and ...

9 years, 3 months ago (2011-09-07 03:51:42 UTC) #2

csilv

On 2011/09/07 03:51:42, Evan Stade wrote: > won't this cause errors in bookmark_page.js when it ...

9 years, 3 months ago (2011-09-07 03:57:45 UTC) #3

csilv

9 years, 3 months ago (2011-09-07 20:09:22 UTC) #5

On 2011/09/07 19:12:23, Evan Stade wrote:
> maybe you should just add 'hidden' for now.
> 
> lgtm

Done.