Make rietveld status handling saner

Make rietveld status handling saner

Add support for a few svn:* properties.
Silently ignore svn:mergeinfo. It's useless once we're switched to git-land anyway.

More testing.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99952

[Dirk Pranke, 2011-09-06 20:21:48]

LGTM w/ one nit.

http://codereview.chromium.org/7840003/diff/1/rietveld.py
File rietveld.py (right):

http://codereview.chromium.org/7840003/diff/1/rietveld.py#newcode129
rietveld.py:129: if status[0] != status.strip():
Nit: wonder if this might be clearer with 'if status != 'D': ? The strip() and
the [0] seem a bit unnecessary.

[M-A Ruel, 2011-09-06 20:23:59]

http://codereview.chromium.org/7840003/diff/1/rietveld.py
File rietveld.py (right):

http://codereview.chromium.org/7840003/diff/1/rietveld.py#newcode129
rietveld.py:129: if status[0] != status.strip():
On 2011/09/06 20:21:48, Dirk Pranke wrote:
> Nit: wonder if this might be clearer with 'if status != 'D': ? The strip() and
> the [0] seem a bit unnecessary.

No because status is a svn status line, which contains 6 characters, by default
they are spaces, e.g. 'A     '.

[Dirk Pranke, 2011-09-06 22:35:36]

http://codereview.chromium.org/7840003/diff/1/rietveld.py
File rietveld.py (right):

http://codereview.chromium.org/7840003/diff/1/rietveld.py#newcode129
rietveld.py:129: if status[0] != status.strip():
On 2011/09/06 20:23:59, Marc-Antoine Ruel wrote:
> On 2011/09/06 20:21:48, Dirk Pranke wrote:
> > Nit: wonder if this might be clearer with 'if status != 'D': ? The strip()
and
> > the [0] seem a bit unnecessary.
> 
> No because status is a svn status line, which contains 6 characters, by
default
> they are spaces, e.g. 'A     '.

Ah, right. LGTM, then.

[commit-bot: I haz the power, 2011-09-07 14:25:46]

Change committed as 99952