Change icon for infobar warning about desktop notifications.

Add new icon for infobar warning about desktop notifications after running it through pngcrush.

BUG=94112
TEST=This change just adds the icon, so there should be no user-visible change yet.

[gideonwald, 2011-09-06 18:17:30]

I wasn't positive that this was the right (a) method or (b) style for adding a
new image to the codebase, but it looks like it's working on my local build. Let
me know!

Thanks,
Gideon

[sail, 2011-09-06 18:31:31]

Looks good!

Before checking in new icons you'll need to run it through pngcrush. You can get
it from here: http://pmt.sourceforge.net/pngcrush/

You can run pngcrush like this:
   pngcrush -d output_folder -reduce -brute input_folder/*.png

http://codereview.chromium.org/7840001/diff/1/chrome/app/theme/theme_resource...
File chrome/app/theme/theme_resources.grd (right):

http://codereview.chromium.org/7840001/diff/1/chrome/app/theme/theme_resource...
chrome/app/theme/theme_resources.grd:67: <include
name="IDR_DESKTOP_NOTIFICATIONS_PERMISSION"
file="desktop_notifications_permission.png" type="BINDATA" />
Could you add an "infobar_" prefix to the image file name?

Also, could you move this line to theme_resources_standard.grd and
theme_resources_large.grd.

For theme_resources_large.grd you'll need a
large_infobar_desktop_notifications_permission.png file that's 2x larger than
the standard one. If you don't have this file then just reference the existing
one and file a bug with alcor to get one made.

[msw, 2011-09-06 18:36:28]

To fix the trybot errors you're seeing, you'll need to split this CL up and land
the new image(s) first.

[gideonwald, 2011-09-06 18:52:40]

Awesome, thank you. Changed this CL to just upload the image file, and I will
make a separate one for the code changes.

I don't have a large icon yet, but I've filed
http://code.google.com/p/chromium/issues/detail?id=95533.

[gideonwald, 2011-09-06 19:05:47]

On 2011/09/06 18:52:40, gideonwald wrote:
> Awesome, thank you. Changed this CL to just upload the image file, and I will
> make a separate one for the code changes.
> 
> I don't have a large icon yet, but I've filed
> http://code.google.com/p/chromium/issues/detail?id=95533.

Although, I must still be doing something wrong, because the try jobs are all
failing on the update step. Any advice much appreciated!

[sail, 2011-09-06 19:11:47]

So any CL with a binary file in it will fail in the try job. Simply commit this
CL once you get an LGTM on it. Once this is commited you can send the 2nd CL to
the try bots.

[sail, 2011-09-06 19:12:31]

On 2011/09/06 18:52:40, gideonwald wrote:
> Awesome, thank you. Changed this CL to just upload the image file, and I will
> make a separate one for the code changes.

Cool, did you run the image through pngcrush? If so can you say that in the CL?

[gideonwald, 2011-09-06 19:18:38]

On 2011/09/06 19:12:31, sail wrote:
> On 2011/09/06 18:52:40, gideonwald wrote:
> > Awesome, thank you. Changed this CL to just upload the image file, and I
will
> > make a separate one for the code changes.
> 
> Cool, did you run the image through pngcrush? If so can you say that in the
CL?

I hadn't yet, but I now have, and have updated the CL description. Thanks!

Who else should I get an LGTM from?

[sail, 2011-09-06 19:21:35]

LGTM!

[gideonwald, 2011-09-06 19:26:46]

On 2011/09/06 19:21:35, sail wrote:
> LGTM!

Submitting. Thanks so much for all your help!

[commit-bot: I haz the power, 2011-09-06 19:31:29]

Try job failure for 7840001-4002 on win for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.