Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 7839038: Make gclient_utils.CheckCallError inherit from subprocess2.CalledProcessError. (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Make gclient_utils.CheckCallError inherit from subprocess2.CalledProcessError. This will simply the transition R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M gclient_utils.py View 2 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
9 years, 3 months ago (2011-09-07 20:10:56 UTC) #1
Dirk Pranke
LGTM.
9 years, 3 months ago (2011-09-07 20:15:14 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-09-08 17:15:16 UTC) #3
Change committed as 100174

Powered by Google App Engine
This is Rietveld 408576698