Issue 7839031: Fixing presubmit error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7839031: Fixing presubmit error. (Closed)

Created:
9 years, 3 months ago by Yang

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixing presubmit error. Committed: http://code.google.com/p/v8/source/detail?r=9181

Patch Set 1 #

Patch Set 2 : Fixing one more issue. #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -12 lines)			Patch
	M	src/runtime.cc	View	1	7 chunks	+21 lines, -12 lines	2 comments	Download
	M	test/mjsunit/string-replace.js	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

Another one of those little mistakes I should have noticed :/ PTAL.

9 years, 3 months ago (2011-09-07 15:35:20 UTC) #1

Yang

This should fix the sputnik test failure. Take another look please.

9 years, 3 months ago (2011-09-07 16:00:39 UTC) #3

Jakob Kummerow

9 years, 3 months ago (2011-09-07 16:11:23 UTC) #4

LGTM with nits.

Go read http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml. All of
it.

http://codereview.chromium.org/7839031/diff/2002/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7839031/diff/2002/src/runtime.cc#newcode2526
src/runtime.cc:2526: int IsSimple() {
nit 1: This is C++. We have bools.
nit 2: A simple getter for my_favorite_variable_ is typically called
my_favorite_variable(), so in this case "simple_hint()".

http://codereview.chromium.org/7839031/diff/2002/src/runtime.cc#newcode2697
src/runtime.cc:2697: bool simple_hint;
nit: trailing underscore please

Expand Messages | Collapse Messages