Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 7839028: Avoid size increase of snapshot. (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 3 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Avoid size increase of snapshot. The prototype of builtin functions is already unwritable, so we don't have to make it so (the default map for functions changes after builtins are initialized). We no longer need to make the prototype non-extensible, since all properties that are ever read by the bultins code has been added and frozen already. Adding properties to the prototype, or changing its __proto__, cannot affect code. Removing these two pieces of initialization code reduces the snapshot size by a few Kb. Committed: http://code.google.com/p/v8/source/detail?r=9166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/v8natives.js View 1 chunk +0 lines, -6 lines 0 comments Download
M test/mjsunit/builtins.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 3 months ago (2011-09-07 11:52:19 UTC) #1
Rico
9 years, 3 months ago (2011-09-07 11:55:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698