Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 7839018: Fix usage error for libresolv - res_ninit on OSX requires res_ndestroy to close (Closed)

Created:
9 years, 3 months ago by groby-ooo-7-16
Modified:
9 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, cbentzel
Visibility:
Public.

Description

Fix usage error for libresolv - res_ninit on OSX requires res_ndestroy to close BUG=95497 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100078

Patch Set 1 #

Patch Set 2 : Resolve merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M net/dns/dns_config_service_posix.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
groby-ooo-7-16
9 years, 3 months ago (2011-09-06 23:49:54 UTC) #1
groby-ooo-7-16
9 years, 3 months ago (2011-09-06 23:51:59 UTC) #2
eroman
LGTM +cc szym: Do you want to review this?
9 years, 3 months ago (2011-09-07 00:49:39 UTC) #3
eroman
9 years, 3 months ago (2011-09-07 01:27:09 UTC) #4
groby-ooo-7-16
On 2011/09/07 01:27:09, eroman wrote: szym: Quick ping if you still want to review this ...
9 years, 3 months ago (2011-09-07 17:55:53 UTC) #5
cbentzel
LGTM szym won't be available until October. On Wed, Sep 7, 2011 at 1:55 PM, ...
9 years, 3 months ago (2011-09-07 18:02:20 UTC) #6
szym
LGTM too. Thanks for the fix. On 2011/09/07 18:02:20, cbentzel wrote: > LGTM > > ...
9 years, 3 months ago (2011-09-07 19:59:11 UTC) #7
commit-bot: I haz the power
List of reviewers changed.
9 years, 3 months ago (2011-09-07 21:10:44 UTC) #8
commit-bot: I haz the power
Can't apply patch for file tools/valgrind/memcheck/suppressions_mac.txt. While running patch -p1 --forward --force; patching file tools/valgrind/memcheck/suppressions_mac.txt ...
9 years, 3 months ago (2011-09-07 22:24:31 UTC) #9
commit-bot: I haz the power
9 years, 3 months ago (2011-09-08 02:14:05 UTC) #10
Change committed as 100078

Powered by Google App Engine
This is Rietveld 408576698