Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7839013: ntp: speed up startup by deferring app icon loads (Closed)

Created:
9 years, 3 months ago by Evan Stade
Modified:
9 years, 3 months ago
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

ntp: speed up startup by deferring app icon loads This will defer the load of app icons on non-selected apps pages until that page is selected. Anecdotally this provides a noticeable speedup when 50ish apps are loaded. I don't think this is really covered by any NTP startup test as it requires a lot of apps installed to have any effect. In lieu of creating such a test (which should be a TODO), I tested locally the time to finish painting by inserting debug statements in NewTabUI::PaintTimeout(). I conducted these tests with the most visited page as the default. For browser startup, this patch reduced paint times from ~560 to ~460 ms on my setup (paint times were pretty consistent across runs). For just NTP startup (without another NTP already open), this patch reduced paint times from ~395 to ~295 ms (and these times were extremely consistent, never varying by more than 10ms from the mean). For reference, I also tested ntp3 and found the browser startup case to be about 570ms and NTP startup to be around 495ms (meaning NTP4 is a win with or without this patch, but especially with this patch). BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M chrome/browser/resources/ntp4/apps_page.js View 7 chunks +46 lines, -14 lines 0 comments Download
M chrome/browser/resources/ntp4/card_slider.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
9 years, 3 months ago (2011-09-06 22:14:24 UTC) #1
arv (Not doing code reviews)
9 years, 3 months ago (2011-09-06 22:21:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698