Issue 7839009: BUG=94920

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7839009: BUG=94920 (Closed)

Created:
9 years, 3 months ago by Cait (Slow)

Modified:
9 years, 3 months ago

Reviewers:
Mark Mentovai, Roger Tawa OOO till Jul 10th, Miranda Callahan

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, SteveT

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Moved from http://codereview.chromium.org/7811020/ (same CL but was on a read-only check-out) BUG=94920 -Related: Check in a new CRX: http://codereview.chromium.org/7828014/ Check in a few GYP changes: http://codereview.chromium.org/7827021/ -Modified profile_impl to search for and auto-install apps found in DIR_DEFAULT_APPS when profile created -Added tracking code for number of extension installs and uninstalls and number of webstore visits. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100727

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -0 lines)			Patch
M	chrome/browser/extensions/crx_installer.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1	5 chunks	+49 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_paths.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_paths.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Cait (Slow)

Hi, This is the same CL (plus the latest minor changes) as http://codereview.chromium.org/7811020/ but I ...

9 years, 3 months ago (2011-09-06 20:19:13 UTC) #1

Mark Mentovai

9 years, 3 months ago (2011-09-07 01:21:01 UTC) #2

If this is indeed identical to the earlier change, then LGTM.