Issue 7839001: NewTabUITest.UpdateUserPrefsVersion test fails on Valgrind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7839001: NewTabUITest.UpdateUserPrefsVersion test fails on Valgrind (Closed)

Created:
9 years, 3 months ago by dhollowa

Modified:
9 years, 3 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Evan Stade

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

NewTabUITest.UpdateUserPrefsVersion test fails on Valgrind Generalizes disabling of NewTabUITest.UpdateUserPrefsVersion. Not just Mac and TSAN anymore. BUG=30367 TEST=Valgrind bots go green on Linux and CrOS TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99767

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -2 lines)			Patch
M	tools/valgrind/gtest_exclude/ui_tests.gtest.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/valgrind/gtest_exclude/ui_tests.gtest-tsan.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/valgrind/gtest_exclude/ui_tests.gtest_mac.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

On 2011/09/06 18:15:51, dhollowa wrote: LGTM. I bet these NTP tests are long outdated. :-(

9 years, 3 months ago (2011-09-07 06:55:52 UTC) #2

dhollowa

9 years, 3 months ago (2011-09-07 14:00:11 UTC) #3

On 2011/09/07 06:55:52, Miranda Callahan wrote:
> On 2011/09/06 18:15:51, dhollowa wrote:
> 
> LGTM. I bet these NTP tests are long outdated. :-(

+estade
Evan, should these tests be replaced/removed with the NTP4 work?

Expand Messages | Collapse Messages